From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Mesih Kilinc <mesihkilinc@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-sunxi@googlegroups.com,
Chen-Yu Tsai <wens@csie.org>,
Russell King <linux@armlinux.org.uk>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Icenowy Zheng <icenowy@aosc.io>, Rob Herring <robh+dt@kernel.org>,
Julian Calaby <julian.calaby@gmail.com>
Subject: Re: [RFC PATCH v2 04/14] dt-bindings: interrupt-controller: Add suniv interrupt-controller
Date: Tue, 20 Nov 2018 09:44:00 +0100 [thread overview]
Message-ID: <20181120084400.sn64fdxbpztaw26h@flea> (raw)
In-Reply-To: <e51824832fac0b981cf886f25efc25056d573da4.1542546735.git.mesihkilinc@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]
Hi,
On Sun, Nov 18, 2018 at 05:17:03PM +0300, Mesih Kilinc wrote:
> Add compatible string for Alwinner suniv F1C100s SoC interrupt
> controller which is stripped version of sun4i
>
> Signed-off-by: Mesih Kilinc <mesihkilinc@gmail.com>
> ---
> .../devicetree/bindings/interrupt-controller/allwinner,sun4i-ic.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-ic.txt b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-ic.txt
> index b290ca1..e04ddb4 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-ic.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-ic.txt
> @@ -2,7 +2,10 @@ Allwinner Sunxi Interrupt Controller
>
> Required properties:
>
> -- compatible : should be "allwinner,sun4i-a10-ic"
> +- compatible: should be "allwinner,<soc-familiy>-<soc-name>-ic" to identify
There's no need to define the pattern, just list the compatibles
supported. Otherwise, you give the idea that all the combinations are
supported, and they aren't.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2018-11-20 8:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 14:16 [RFC PATCH v2 00/14] initial support for "suniv" Allwinner new ARM9 SoC Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 01/14] ARM: add CONFIG_ARCH_SUNXI_V7 for differentiate ARMv5/v7 Allwinner SoCs Mesih Kilinc
2018-11-20 8:40 ` Maxime Ripard
2018-11-18 14:17 ` [RFC PATCH v2 02/14] dt-bindings: arm: Add new Allwinner ARMv5 F1C100s SoC Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 03/14] ARM: sunxi: add Allwinner ARMv5 SoCs Mesih Kilinc
2018-11-20 8:42 ` Maxime Ripard
2018-11-20 23:36 ` Icenowy Zheng
2018-11-18 14:17 ` [RFC PATCH v2 04/14] dt-bindings: interrupt-controller: Add suniv interrupt-controller Mesih Kilinc
2018-11-20 8:44 ` Maxime Ripard [this message]
2018-11-18 14:17 ` [RFC PATCH v2 05/14] irqchip/sun4i: add support for suniv interrupt controller Mesih Kilinc
2018-11-20 8:48 ` Maxime Ripard
2018-11-18 14:17 ` [RFC PATCH v2 06/14] dt-bindings: timer: Add Allwinner suniv timer Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 07/14] clocksource: sun4i: add a compatible for suniv Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 08/14] clocksource/drivers/sun4i: register as sched_clock on suniv Mesih Kilinc
2018-11-20 8:49 ` Maxime Ripard
2018-11-18 14:17 ` [RFC PATCH v2 09/14] dt-bindings: pinctrl: Add Allwinner suniv F1C100s pinctrl Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 10/14] pinctrl: sunxi: add support for suniv F1C100s (newer F-series SoCs) Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 11/14] dt-bindings: clock: Add Allwinner suniv F1C100s CCU Mesih Kilinc
2018-11-20 8:52 ` Maxime Ripard
2018-11-18 14:17 ` [RFC PATCH v2 12/14] clk: sunxi-ng: add support for suniv F1C100s SoC Mesih Kilinc
2018-11-18 14:17 ` [RFC PATCH v2 13/14] ARM: dts: suniv: add initial DTSI file for F1C100s Mesih Kilinc
2018-11-20 8:55 ` Maxime Ripard
2018-11-18 14:17 ` [RFC PATCH v2 14/14] ARM: suniv: f1c100s: add device tree for Lichee Pi Nano Mesih Kilinc
2018-11-20 8:56 ` [RFC PATCH v2 00/14] initial support for "suniv" Allwinner new ARM9 SoC Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120084400.sn64fdxbpztaw26h@flea \
--to=maxime.ripard@bootlin.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=julian.calaby@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mesihkilinc@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).