From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Russell King" <linux@armlinux.org.uk>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"Greg Ungerer" <gerg@linux-m68k.org>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Paul Burton" <paul.burton@mips.com>,
"James Hogan" <jhogan@kernel.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Huacai Chen" <chenhc@lemote.com>, "Guan Xuetao" <gxt@pku.edu.cn>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"linux-m68k@lists.linux-m68k.org"
<linux-m68k@lists.linux-m68k.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: Add (devm_)clk_get_optional() functions
Date: Tue, 20 Nov 2018 13:12:48 +0200 [thread overview]
Message-ID: <20181120111248.GW10650@smile.fi.intel.com> (raw)
In-Reply-To: <TY1PR01MB176982D5E11A665D0DCC9E31F5D90@TY1PR01MB1769.jpnprd01.prod.outlook.com>
On Tue, Nov 20, 2018 at 10:53:33AM +0000, Phil Edworthy wrote:
> On 20 November 2018 10:39 Andy Shevchenko wrote:
> > On Mon, Nov 19, 2018 at 02:12:59PM +0000, Phil Edworthy wrote:
> > > This adds clk_get_optional() and devm_clk_get_optional() functions to
> > > get optional clocks.
> > > They behave the same as (devm_)clk_get except where there is no clock
> > > producer. In this case, instead of returning -ENOENT, the function
> > > returns NULL. This makes error checking simpler and allows
> > > clk_prepare_enable, etc to be called on the returned reference without
> > > additional checks.
> > > - Instead of messing with the core functions, simply wrap them for the
> > > _optional() versions. By putting clk_get_optional() inline in the header
> > > file, we can get rid of the arch specific patches as well.
> > Fine if it would have no surprises with error handling.
> There shouldn't be any surprises. My earlier attempts at implementing this
> were hampered by the fact that of_clk_get_by_name() can return -EINVAL
> in some circumstances. By directly wrapping the (devm_)clk_get() functions
> that problem goes away.
Good!
After my comments being addressed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > + if (ERR_PTR(-ENOENT))
> Huh? That wasn't the code I sent...
Yup, it's my wrong editing flow. Anyway, you got the idea.
> > > + return NULL;
> > > + else
> > > + return clk;
> > return clk == ERR_PTR(-ENOENT) ? NULL : clk;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-20 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 14:12 [PATCH] clk: Add (devm_)clk_get_optional() functions Phil Edworthy
2018-11-20 10:38 ` Andy Shevchenko
2018-11-20 10:53 ` Phil Edworthy
2018-11-20 11:12 ` Andy Shevchenko [this message]
2018-11-20 12:56 ` Uwe Kleine-König
2018-11-20 13:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120111248.GW10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=chenhc@lemote.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=gxt@pku.edu.cn \
--cc=jhogan@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=paul.burton@mips.com \
--cc=phil.edworthy@renesas.com \
--cc=ralf@linux-mips.org \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).