From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE61C04EBC for ; Tue, 20 Nov 2018 13:24:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F8CE206BB for ; Tue, 20 Nov 2018 13:24:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F8CE206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727634AbeKTXxG (ORCPT ); Tue, 20 Nov 2018 18:53:06 -0500 Received: from mail.bootlin.com ([62.4.15.54]:56229 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbeKTXxG (ORCPT ); Tue, 20 Nov 2018 18:53:06 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id D7B0C206A1; Tue, 20 Nov 2018 14:23:57 +0100 (CET) Received: from localhost (aaubervilliers-681-1-13-146.w90-88.abo.wanadoo.fr [90.88.134.146]) by mail.bootlin.com (Postfix) with ESMTPSA id A534F2037D; Tue, 20 Nov 2018 14:23:57 +0100 (CET) Date: Tue, 20 Nov 2018 14:23:57 +0100 From: Maxime Ripard To: Jagan Teki Cc: Maarten Lankhorst , Sean Paul , David Airlie , Rob Herring , Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Thierry Reding , Mark Rutland , dri-devel , devicetree , linux-kernel , linux-arm-kernel , Michael Trimarchi , TL Lim , linux-sunxi@googlegroups.com, linux-amarula@amarulasolutions.com Subject: Re: [PATCH v2 01/12] drm/sun4i: sun6i_mipi_dsi: Compute burst mode loop N1 instruction delay Message-ID: <20181120132357.xge6gkurjjjvwi2i@flea> References: <20181116163916.29621-1-jagan@amarulasolutions.com> <20181116163916.29621-2-jagan@amarulasolutions.com> <20181119082707.kbsw2gyntxxbh6no@flea> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xeqpoomfu3vqgjcj" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xeqpoomfu3vqgjcj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 19, 2018 at 04:28:29PM +0530, Jagan Teki wrote: > On Mon, Nov 19, 2018 at 1:57 PM Maxime Ripard = wrote: > > > > On Fri, Nov 16, 2018 at 10:09:05PM +0530, Jagan Teki wrote: > > > Loop N1 instruction delay for burst mode lcd panel are > > > computed as per BSP code. > > > > > > Reference code is available in BSP (from linux-sunxi > > > drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > > > > > > dsi_dev[sel]->dsi_inst_loop_num.bits.loop_n1=3D > > > (panel->lcd_ht-panel->lcd_x)*(150)/(panel->lcd_dclk_freq*8) - 50; > > > =3D> (((mode->htotal - mode->hdisplay) * 150) / > > > ((mode->clock / 1000) * 8)) - 50; > > > > > > So use the similar computation for loop N1 delay. > > > > > > Signed-off-by: Jagan Teki > > > > *why* are you doing this? What is it fixing? on which devices? >=20 > You mentioned the separate function to compute the delay for all modes > [1], ie what I did. did I missing anything? You're missing that you are never explaining why that patch is needed in the first place. Or answering the question I asked a couple of lines above. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --xeqpoomfu3vqgjcj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCW/QK7QAKCRDj7w1vZxhR xdm1AQC1Lzg72RV3LZzLZwYcohq7q/Jd8BR7xbejfuCL1/fi1QD/bYPvFfmtHaZw GW/rdskjjOHFzxqrKa68Y83eQGBuZQ8= =f7XQ -----END PGP SIGNATURE----- --xeqpoomfu3vqgjcj--