From: Johan Hovold <firstname.lastname@example.org> To: Rob Herring <email@example.com> Cc: Johan Hovold <firstname.lastname@example.org>, Greg Kroah-Hartman <email@example.com>, Jiri Slaby <firstname.lastname@example.org>, Andrey Smirnov <email@example.com>, "open list:SERIAL DRIVERS" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org> Subject: Re: [PATCH 0/4] serdev: make serdev_device_write() more usable Date: Tue, 20 Nov 2018 18:11:07 +0100 [thread overview] Message-ID: <20181120171107.GI19900@localhost> (raw) In-Reply-To: <CAL_JsqJyTVsN1=YpeHNtTr+Tpw9Qmqd=mWfhg-d3WgzUX7DqKw@mail.gmail.com> On Mon, Nov 19, 2018 at 09:16:35AM -0600, Rob Herring wrote: > On Wed, Nov 14, 2018 at 9:10 AM Johan Hovold <email@example.com> wrote: > > > > This series make the synchronous serdev_device_write() helper more > > usable by > > > > 1) allowing drivers to pass a zero timeout to indicate that they > > want to wait forever; > > > > 2) returning the number of bytes actually written (buffered) > > if the helper is interrupted; > > > > 3) make the helper use interruptible wait so that the helper can > > be used on behalf of user space. > > > > Finally, the two write functions are documented using kernel-doc. > > > > Turns out I was using the wrong timeout for two gnss drivers that > > expected the helper to wait indefinitely. I've fixed up those separately > > (by using MAX_SCHEDULE_TIMEOUT for now), but for the helper to be usable > > when using flow control we really want it to be interruptible. > > > > Besides the two gnss drivers, there's currently only one other in-kernel > > user of this helper and that driver (rave-sp) uses a non-zero timeout > > and doesn't check the return value and therefore does not need to be > > updated. > > > > Note that this series depends on the two above mentioned GNSS fixes > > (submitted for v4.20-rc3). > > > > Johan > > > > > > Johan Hovold (4): > > serdev: use zero to indicate infinite write timeout > > serdev: make synchronous write return bytes written > > serdev: make synchronous write helper interruptible > > serdev: document the write functions using kernel-doc > > Other than the one nit, for the series: > > Reviewed-by: Rob Herring <firstname.lastname@example.org> Thanks for reviewing. Greg, note that these still depend on the two gnss fixes currently in your char-misc-linus branch. Johan
prev parent reply other threads:[~2018-11-20 17:11 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-14 15:09 Johan Hovold 2018-11-14 15:09 ` [PATCH 1/4] serdev: use zero to indicate infinite write timeout Johan Hovold 2018-11-14 15:09 ` [PATCH 2/4] serdev: make synchronous write return bytes written Johan Hovold 2018-11-19 15:15 ` Rob Herring 2018-11-20 17:09 ` Johan Hovold 2018-11-14 15:09 ` [PATCH 3/4] serdev: make synchronous write helper interruptible Johan Hovold 2018-11-14 15:09 ` [PATCH 4/4] serdev: document the write functions using kernel-doc Johan Hovold 2018-11-19 15:16 ` [PATCH 0/4] serdev: make serdev_device_write() more usable Rob Herring 2018-11-20 17:11 ` Johan Hovold [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181120171107.GI19900@localhost \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/4] serdev: make serdev_device_write() more usable' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).