From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 1/2] irq/irq_sim: provide irq_sim_fire_edge()
Date: Tue, 20 Nov 2018 18:17:42 +0100 [thread overview]
Message-ID: <20181120171742.gkwb4s4qbcqvnefj@pengutronix.de> (raw)
In-Reply-To: <20181120134032.31645-2-brgl@bgdev.pl>
On Tue, Nov 20, 2018 at 02:40:31PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The irq_sim irqchip doesn't allow to configure the sensitivity so every
> call to irq_sim_fire() fires a dummy interrupt. This used to not matter
> for gpio-mockup (one of the irq_sim users) until commit fa38869b0161
> ("gpiolib: Don't support irq sharing for userspace") which made it
> impossible for gpio-mockup to ignore certain events (e.g. only receive
> notifications about rising edge events).
>
> Introduce a specialized variant of irq_sim_fire() which takes another
> argument called edge. allowing to specify the trigger type for the
> dummy interrupt.
I wonder if it's worth the effort to fix irq_sim. If you take a look in
my gpio-simulator patch, it is trivial to get it right without external
help with an amount of code that is usual for a driver that handles
irqs.
> @@ -161,12 +171,28 @@ EXPORT_SYMBOL_GPL(devm_irq_sim_init);
> */
> void irq_sim_fire(struct irq_sim *sim, unsigned int offset)
> {
> - if (sim->irqs[offset].enabled) {
> + /* Don't care about the edge. */
> + irq_sim_fire_edge(sim, offset, IRQ_TYPE_EDGE_BOTH);
Conceptually irq_sim_fire_edge should be defined above irq_sim_fire.
> +EXPORT_SYMBOL_GPL(irq_sim_fire);
> +
> +/**
> + * irq_sim_fire_edge - Enqueue an interrupt, specify the edge.
> + *
> + * @sim: The interrupt simulator object.
> + * @offset: Offset of the simulated interrupt which should be fired.
> + * edge: Edge of the interrupt (IRQ_TYPE_EDGE_RISING/FALLING).
> + */
> +void irq_sim_fire_edge(struct irq_sim *sim, unsigned int offset, int edge)
> +{
> + struct irq_sim_irq_ctx *irq = &sim->irqs[offset];
> +
> + if (irq->enabled && (irq->edge & edge)) {
> set_bit(offset, sim->work_ctx.pending);
> irq_work_queue(&sim->work_ctx.work);
> }
> }
> -EXPORT_SYMBOL_GPL(irq_sim_fire);
> +EXPORT_SYMBOL_GPL(irq_sim_fire_edge);
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-11-20 17:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 13:40 [PATCH 0/2] irq/irq_sim: provide a specialized variant of irq_sim_fire() Bartosz Golaszewski
2018-11-20 13:40 ` [PATCH 1/2] irq/irq_sim: provide irq_sim_fire_edge() Bartosz Golaszewski
2018-11-20 17:17 ` Uwe Kleine-König [this message]
2018-11-21 16:34 ` Bartosz Golaszewski
2018-11-21 19:15 ` Uwe Kleine-König
2018-11-23 15:59 ` Bartosz Golaszewski
2018-11-25 21:18 ` Uwe Kleine-König
2018-11-29 18:14 ` Bartosz Golaszewski
2018-11-30 22:26 ` Linus Walleij
2018-12-02 12:29 ` Marc Zyngier
2018-12-02 17:00 ` Bartosz Golaszewski
2018-12-02 21:56 ` Uwe Kleine-König
2018-12-02 22:20 ` Bartosz Golaszewski
2018-12-03 10:23 ` Bartosz Golaszewski
2018-12-03 10:49 ` Uwe Kleine-König
2018-12-03 10:57 ` Bartosz Golaszewski
2018-12-03 11:06 ` Uwe Kleine-König
2018-12-05 12:19 ` Linus Walleij
2018-12-05 12:38 ` Bartosz Golaszewski
2018-12-05 12:55 ` Linus Walleij
2018-12-17 10:32 ` Bartosz Golaszewski
2018-12-17 12:59 ` Uwe Kleine-König
2018-12-17 13:59 ` Bartosz Golaszewski
2018-12-05 13:20 ` Uwe Kleine-König
2018-12-14 14:07 ` Linus Walleij
2018-12-17 11:19 ` Uwe Kleine-König
2018-11-20 13:40 ` [PATCH 2/2] gpio: mockup: use irq_sim_fire_edge() Bartosz Golaszewski
2018-12-03 11:09 ` Uwe Kleine-König
2018-12-11 14:15 ` Uwe Kleine-König
2018-12-11 15:38 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120171742.gkwb4s4qbcqvnefj@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).