From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C5AEC46475 for ; Tue, 20 Nov 2018 21:14:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9D2920685 for ; Tue, 20 Nov 2018 21:13:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="ZDvnt3vp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9D2920685 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726234AbeKUHoq (ORCPT ); Wed, 21 Nov 2018 02:44:46 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46757 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbeKUHoq (ORCPT ); Wed, 21 Nov 2018 02:44:46 -0500 Received: by mail-pl1-f193.google.com with SMTP id t13so2088035ply.13 for ; Tue, 20 Nov 2018 13:13:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=g1bO/y/2VljowgSDwNt+uQ3GsVQIQPS9jig892qfnyQ=; b=ZDvnt3vpBWvFsU4v6GiQth05+Sjx4CUFe7zzmRYBytBEQPqs46o/4QaK9jvbxVCZ1B ASsuUX7lnoef4Ux4lHcKvEQJIzArP17Tx23SYEH0eJuQliNpi8Bjccf6YXV+9m8tz0Os cnHCCeHTbZHkvo5sUT1THA8b7tC+/c2lPWc6w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=g1bO/y/2VljowgSDwNt+uQ3GsVQIQPS9jig892qfnyQ=; b=W0Dp9S02pk8IdPjEUpcW7FxqhTvuIWo/GOCy7o2ZOYh2yLLj/YWjCYrLepAlt4hXls nC90IO5Mst9dUgCzTOsf40CpOwk0xpRmVYvHPaHDQj+MVH7ejsyW91G/bChbA3yVVwq3 o2BLlfhUaNGlQtF6IzNI7dZhPw5oo0OSfEHn9GKx6ZGgTOCN4rSen/6Yzwaspf7wgWYR +TMNpzW2ia7RU9031d1+g+bcbE8jqDEBRCMzA6YX6udIm0a4ai1IPCkXW/P81ppNsJHR 7b55+jVOzyemZOjkHAt6YhgKKWw8ZrLbP50vkapwsJ+ifH32z5NCyJRvQcvIw4d3Pz2+ cb6Q== X-Gm-Message-State: AGRZ1gLFeTRR25XfVgAHvNKxQt7CZgrgf+73bcag9ttsjLVCAdm+h0pB hD2CsHZIwxlzmEyqKE+/N5IhPw== X-Google-Smtp-Source: AJdET5dy2kejEPrWBkugDqa0cRG1oIr9cWnMpOEzMRVy0kwIItB0w0+4oQcZTlV7BK1tg68AiBaJmg== X-Received: by 2002:a62:ed09:: with SMTP id u9-v6mr3802744pfh.188.1542748417710; Tue, 20 Nov 2018 13:13:37 -0800 (PST) Received: from localhost ([2620:0:1000:1601:3aef:314f:b9ea:889f]) by smtp.gmail.com with ESMTPSA id 6sm38611591pfv.30.2018.11.20.13.13.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Nov 2018 13:13:36 -0800 (PST) Date: Tue, 20 Nov 2018 13:13:35 -0800 From: Joel Fernandes To: Andy Lutomirski Cc: Stephen Rothwell , Andy Lutomirski , LKML , Andrew Morton , Hugh Dickins , Jann Horn , Khalid Aziz , Linux API , "open list:KERNEL SELFTEST FRAMEWORK" , Linux-MM , marcandre.lureau@redhat.com, Matthew Wilcox , Mike Kravetz , Shuah Khan Subject: Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust Message-ID: <20181120211335.GC22801@google.com> References: <20181120052137.74317-1-joel@joelfernandes.org> <20181120183926.GA124387@google.com> <20181121070658.011d576d@canb.auug.org.au> <469B80CB-D982-4802-A81D-95AC493D7E87@amacapital.net> <20181120204710.GB22801@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 20, 2018 at 02:02:49PM -0700, Andy Lutomirski wrote: > > > On Nov 20, 2018, at 1:47 PM, Joel Fernandes wrote: > > > >> On Tue, Nov 20, 2018 at 01:33:18PM -0700, Andy Lutomirski wrote: > >> > >>> On Nov 20, 2018, at 1:07 PM, Stephen Rothwell wrote: > >>> > >>> Hi Joel, > >>> > >>>>> On Tue, 20 Nov 2018 10:39:26 -0800 Joel Fernandes wrote: > >>>>> > >>>>> On Tue, Nov 20, 2018 at 07:13:17AM -0800, Andy Lutomirski wrote: > >>>>> On Mon, Nov 19, 2018 at 9:21 PM Joel Fernandes (Google) > >>>>> wrote: > >>>>>> > >>>>>> A better way to do F_SEAL_FUTURE_WRITE seal was discussed [1] last week > >>>>>> where we don't need to modify core VFS structures to get the same > >>>>>> behavior of the seal. This solves several side-effects pointed out by > >>>>>> Andy [2]. > >>>>>> > >>>>>> [1] https://lore.kernel.org/lkml/20181111173650.GA256781@google.com/ > >>>>>> [2] https://lore.kernel.org/lkml/69CE06CC-E47C-4992-848A-66EB23EE6C74@amacapital.net/ > >>>>>> > >>>>>> Suggested-by: Andy Lutomirski > >>>>>> Fixes: 5e653c2923fd ("mm: Add an F_SEAL_FUTURE_WRITE seal to memfd") > >>>>> > >>>>> What tree is that commit in? Can we not just fold this in? > >>>> > >>>> It is in linux-next. Could we keep both commits so we have the history? > >>> > >>> Well, its in Andrew's mmotm, so its up to him. > >>> > >>> > >> > >> Unless mmotm is more magical than I think, the commit hash in your fixed > >> tag is already nonsense. mmotm gets rebased all the time, and is only > >> barely a git tree. > > > > I wouldn't go so far to call it nonsense. It was a working patch, it just did > > things differently. Your help with improving the patch is much appreciated. > > I’m not saying the patch is nonsense — I’m saying the *hash* may be > nonsense. akpm uses a bunch of .patch files and all kinds of crazy scripts, > and the mmotm.git tree is not stable at all. > Oh, ok. Sorry for misunderstanding and thanks for clarification. :-) > > I am Ok with whatever Andrew wants to do, if it is better to squash it with > > the original, then I can do that and send another patch. > > > > > > From experience, Andrew will food in fixups on request :) Andrew, could you squash this patch into the one titled ("mm: Add an F_SEAL_FUTURE_WRITE seal to memfd")? That one was already picked up by -next but I imagine you might have a crazy script as Andy pointed out for exactly these situations. ;-) thanks, - Joel