From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rajendra Nayak <rnayak@codeaurora.org>
Cc: ulf.hansson@linaro.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Stephen Boyd <sboyd@kernel.org>, Nishanth Menon <nm@ti.com>,
niklas.cassel@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] PM / Domains: Propagate performance state updates
Date: Wed, 21 Nov 2018 11:11:40 +0530 [thread overview]
Message-ID: <20181121054140.c64qf6m2kl2rfc5d@vireshk-i7> (raw)
In-Reply-To: <68a3294f-5556-4b5f-f8c7-79c20b5c70fb@codeaurora.org>
On 21-11-18, 11:01, Rajendra Nayak wrote:
> I would think this is analogous to a driver calling clk_set_rate() first and
> then a clk_enable(), which is certainly valid.
> So my question is, if calling a dev_pm_genpd_set_performance_state()
> and then runtime enabling the device would work (and take care of propagating the performance
> state).
Two things here..
- First, it should work.
- Second, we don't look at device RPM states but only if a genpd is on
or off. Maybe we should look at device states as well, but then we
need to initiate set-performance-state routine from runtime enable
as well. But that is completely different work and would require its
own series.
> In my testing I found it does not.
As I said, we don't do anything in RPM enable of the device currently,
but only during genpd_power_on(). So if the genpd was previously
disabled, RPM enable of the device should have done propagation of
states as well. Otherwise, we should already have take care of the
vote from the device. So, it should have worked.
Needs some investigation on why this isn't working for you.
--
viresh
next prev parent reply other threads:[~2018-11-21 5:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 6:36 [PATCH 0/4] PM / Domains: Allow performance state propagation Viresh Kumar
2018-11-05 6:36 ` [PATCH 1/4] OPP: Add dev_pm_opp_xlate_performance_state() helper Viresh Kumar
2018-11-21 5:04 ` Rajendra Nayak
2018-11-21 5:17 ` Viresh Kumar
2018-11-21 6:06 ` Viresh Kumar
2018-11-21 6:18 ` Rajendra Nayak
2018-11-22 6:08 ` Viresh Kumar
2018-11-23 9:11 ` Viresh Kumar
2018-11-23 9:55 ` Viresh Kumar
2018-11-05 6:36 ` [PATCH 2/4] PM / Domains: Save OPP table pointer in genpd Viresh Kumar
2018-11-05 6:36 ` [PATCH 3/4] PM / Domains: Factorize dev_pm_genpd_set_performance_state() Viresh Kumar
2018-11-05 6:36 ` [PATCH 4/4] PM / Domains: Propagate performance state updates Viresh Kumar
2018-11-21 5:03 ` Rajendra Nayak
2018-11-21 5:16 ` Viresh Kumar
2018-11-21 5:31 ` Rajendra Nayak
2018-11-21 5:41 ` Viresh Kumar [this message]
2018-11-21 5:42 ` Rajendra Nayak
2018-11-21 6:36 ` Viresh Kumar
2018-11-21 6:51 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121054140.c64qf6m2kl2rfc5d@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).