From: Peter Zijlstra <peterz@infradead.org>
To: Quentin Perret <quentin.perret@arm.com>
Cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, gregkh@linuxfoundation.org,
mingo@redhat.com, dietmar.eggemann@arm.com,
morten.rasmussen@arm.com, chris.redpath@arm.com,
patrick.bellasi@arm.com, valentin.schneider@arm.com,
vincent.guittot@linaro.org, thara.gopinath@linaro.org,
viresh.kumar@linaro.org, tkjos@google.com,
joel@joelfernandes.org, smuckle@google.com,
adharmap@codeaurora.org, skannan@codeaurora.org,
pkondeti@codeaurora.org, juri.lelli@redhat.com,
edubezval@gmail.com, srinivas.pandruvada@linux.intel.com,
currojerez@riseup.net, javi.merino@kernel.org
Subject: Re: [PATCH v9 13/15] sched/fair: Introduce an energy estimation helper function
Date: Wed, 21 Nov 2018 15:28:03 +0100 [thread overview]
Message-ID: <20181121142803.GF2113@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20181119141857.8625-14-quentin.perret@arm.com>
On Mon, Nov 19, 2018 at 02:18:55PM +0000, Quentin Perret wrote:
> +static long
> +compute_energy(struct task_struct *p, int dst_cpu, struct perf_domain *pd)
> +{
> + long util, max_util, sum_util, energy = 0;
> + int cpu;
> +
> + for (; pd; pd = pd->next) {
> + max_util = sum_util = 0;
> + /*
> + * The capacity state of CPUs of the current rd can be driven by
> + * CPUs of another rd if they belong to the same performance
> + * domain. So, account for the utilization of these CPUs too
> + * by masking pd with cpu_online_mask instead of the rd span.
> + *
> + * If an entire performance domain is outside of the current rd,
> + * it will not appear in its pd list and will not be accounted
> + * by compute_energy().
> + */
> + for_each_cpu_and(cpu, perf_domain_span(pd), cpu_online_mask) {
Should that not be cpu_active_mask ?
> + util = cpu_util_next(cpu, p, dst_cpu);
> + util = schedutil_energy_util(cpu, util);
> + max_util = max(util, max_util);
> + sum_util += util;
> + }
> +
> + energy += em_pd_energy(pd->em_pd, max_util, sum_util);
> + }
> +
> + return energy;
> +}
next prev parent reply other threads:[~2018-11-21 14:28 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 14:18 [PATCH v9 00/15] Energy Aware Scheduling Quentin Perret
2018-11-19 14:18 ` [PATCH v9 01/15] sched: Relocate arch_scale_cpu_capacity Quentin Perret
2018-11-19 14:18 ` [PATCH v9 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling Quentin Perret
2018-11-20 4:46 ` Viresh Kumar
2018-11-20 15:25 ` Peter Zijlstra
2018-11-20 15:53 ` Quentin Perret
2018-11-19 14:18 ` [PATCH v9 03/15] PM: Introduce an Energy Model management framework Quentin Perret
2018-11-19 14:18 ` [PATCH v9 04/15] PM / EM: Expose the Energy Model in sysfs Quentin Perret
2018-11-19 14:18 ` [PATCH v9 05/15] sched/topology: Reference the Energy Model of CPUs when available Quentin Perret
2018-11-19 14:18 ` [PATCH v9 06/15] sched/topology: Lowest CPU asymmetry sched_domain level pointer Quentin Perret
2018-11-19 14:18 ` [PATCH v9 07/15] sched/topology: Disable EAS on inappropriate platforms Quentin Perret
2018-11-19 14:18 ` [PATCH v9 08/15] sched/topology: Make Energy Aware Scheduling depend on schedutil Quentin Perret
2018-11-22 14:04 ` Peter Zijlstra
2018-11-22 15:49 ` Rafael J. Wysocki
2018-11-22 15:56 ` Quentin Perret
2018-11-19 14:18 ` [PATCH v9 09/15] sched: Introduce sched_energy_present static key Quentin Perret
2018-11-21 13:08 ` Peter Zijlstra
2018-11-21 15:14 ` Quentin Perret
2018-11-22 9:17 ` Quentin Perret
2018-11-22 9:32 ` Quentin Perret
2018-11-22 10:25 ` Peter Zijlstra
2018-11-22 15:25 ` Quentin Perret
2018-11-22 15:51 ` Rafael J. Wysocki
2018-11-22 15:55 ` Quentin Perret
2018-11-19 14:18 ` [PATCH v9 10/15] sched: Introduce a sysctl for Energy Aware Scheduling Quentin Perret
2018-11-19 14:18 ` [PATCH v9 11/15] sched/fair: Clean-up update_sg_lb_stats parameters Quentin Perret
2018-11-19 14:18 ` [PATCH v9 12/15] sched: Add over-utilization/tipping point indicator Quentin Perret
2018-11-19 14:18 ` [PATCH v9 13/15] sched/fair: Introduce an energy estimation helper function Quentin Perret
2018-11-21 14:28 ` Peter Zijlstra [this message]
2018-11-21 16:05 ` Quentin Perret
2018-11-22 13:56 ` Peter Zijlstra
2018-11-19 14:18 ` [PATCH v9 14/15] sched/fair: Select an energy-efficient CPU on task wake-up Quentin Perret
2018-11-19 14:18 ` [PATCH v9 15/15] OPTIONAL: cpufreq: dt: Register an Energy Model Quentin Perret
2018-11-20 6:19 ` Viresh Kumar
2018-11-20 10:01 ` Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121142803.GF2113@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=adharmap@codeaurora.org \
--cc=chris.redpath@arm.com \
--cc=currojerez@riseup.net \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=javi.merino@kernel.org \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@arm.com \
--cc=pkondeti@codeaurora.org \
--cc=quentin.perret@arm.com \
--cc=rjw@rjwysocki.net \
--cc=skannan@codeaurora.org \
--cc=smuckle@google.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=thara.gopinath@linaro.org \
--cc=tkjos@google.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).