From: Andrew Morton <akpm@linux-foundation.org>
To: john.hubbard@gmail.com
Cc: linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
John Hubbard <jhubbard@nvidia.com>,
Dan Williams <dan.j.williams@intel.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH] mm/gup: finish consolidating error handling
Date: Wed, 21 Nov 2018 14:44:04 -0800 [thread overview]
Message-ID: <20181121144404.efdab6dbccd7780034a55e1d@linux-foundation.org> (raw)
In-Reply-To: <20181121081402.29641-2-jhubbard@nvidia.com>
On Wed, 21 Nov 2018 00:14:02 -0800 john.hubbard@gmail.com wrote:
> Commit df06b37ffe5a4 ("mm/gup: cache dev_pagemap while pinning pages")
> attempted to operate on each page that get_user_pages had retrieved. In
> order to do that, it created a common exit point from the routine.
> However, one case was missed, which this patch fixes up.
>
> Also, there was still an unnecessary shadow declaration (with a
> different type) of the "ret" variable, which this patch removes.
>
What is the bug which this supposedly fixes and what is that bug's
user-visible impact?
next prev parent reply other threads:[~2018-11-21 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 8:14 [PATCH 0/1] mm/gup: finish consolidating error handling john.hubbard
2018-11-21 8:14 ` [PATCH] " john.hubbard
2018-11-21 22:44 ` Andrew Morton [this message]
2018-11-22 7:48 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121144404.efdab6dbccd7780034a55e1d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).