From: Thierry Reding <thierry.reding@gmail.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 09/19] mailbox: altera: Use device-managed registration API
Date: Wed, 21 Nov 2018 15:54:19 +0100 [thread overview]
Message-ID: <20181121145429.7582-10-thierry.reding@gmail.com> (raw)
In-Reply-To: <20181121145429.7582-1-thierry.reding@gmail.com>
From: Thierry Reding <treding@nvidia.com>
Get rid of some boilerplate driver removal code by using the newly added
device-managed registration API.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/mailbox/mailbox-altera.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/mailbox/mailbox-altera.c b/drivers/mailbox/mailbox-altera.c
index bcb29df9549e..397e25ddae29 100644
--- a/drivers/mailbox/mailbox-altera.c
+++ b/drivers/mailbox/mailbox-altera.c
@@ -341,7 +341,7 @@ static int altera_mbox_probe(struct platform_device *pdev)
}
}
- ret = mbox_controller_register(&mbox->controller);
+ ret = devm_mbox_controller_register(&pdev->dev, &mbox->controller);
if (ret) {
dev_err(&pdev->dev, "Register mailbox failed\n");
goto err;
@@ -352,18 +352,6 @@ static int altera_mbox_probe(struct platform_device *pdev)
return ret;
}
-static int altera_mbox_remove(struct platform_device *pdev)
-{
- struct altera_mbox *mbox = platform_get_drvdata(pdev);
-
- if (!mbox)
- return -EINVAL;
-
- mbox_controller_unregister(&mbox->controller);
-
- return 0;
-}
-
static const struct of_device_id altera_mbox_match[] = {
{ .compatible = "altr,mailbox-1.0" },
{ /* Sentinel */ }
@@ -373,7 +361,6 @@ MODULE_DEVICE_TABLE(of, altera_mbox_match);
static struct platform_driver altera_mbox_driver = {
.probe = altera_mbox_probe,
- .remove = altera_mbox_remove,
.driver = {
.name = DRIVER_NAME,
.of_match_table = altera_mbox_match,
--
2.19.1
next prev parent reply other threads:[~2018-11-21 14:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 14:54 [PATCH 00/19] mailbox: Device-managed registration Thierry Reding
2018-11-21 14:54 ` [PATCH 01/19] mailbox: Add device-managed registration functions Thierry Reding
2018-11-21 14:54 ` [PATCH 02/19] mailbox: arm-mhu: Use device-managed registration API Thierry Reding
2018-11-21 14:54 ` [PATCH 03/19] mailbox: bcm2835: " Thierry Reding
2018-11-21 14:54 ` [PATCH 04/19] mailbox: bcm-flexrm: " Thierry Reding
2018-11-21 14:54 ` [PATCH 05/19] mailbox: bcm-pdc: " Thierry Reding
2018-11-21 14:54 ` [PATCH 06/19] mailbox: hi3660: " Thierry Reding
2018-11-21 14:54 ` [PATCH 07/19] mailbox: hi6220: " Thierry Reding
2018-11-21 14:54 ` [PATCH 08/19] mailbox: imx: " Thierry Reding
2018-11-21 14:54 ` Thierry Reding [this message]
2018-11-21 14:54 ` [PATCH 10/19] mailbox: sti: " Thierry Reding
2018-11-21 14:54 ` [PATCH 11/19] mailbox: xgene-slimpro: " Thierry Reding
2018-11-21 14:54 ` [PATCH 12/19] mailbox: mtk-cmdq: " Thierry Reding
2018-11-21 14:54 ` [PATCH 13/19] mailbox: mtk-cmdq: Remove needless devm_kfree() calls Thierry Reding
2018-11-21 14:54 ` [PATCH 14/19] mailbox: omap: Use device-managed registration API Thierry Reding
2018-11-21 14:54 ` [PATCH 15/19] mailbox: platform-mhu: " Thierry Reding
2018-11-21 14:54 ` [PATCH 16/19] mailbox: qcom-apcs: " Thierry Reding
2018-11-21 14:54 ` [PATCH 17/19] mailbox: rockchip: " Thierry Reding
2018-11-21 14:54 ` [PATCH 18/19] mailbox: stm32-ipcc: " Thierry Reding
2018-11-21 14:54 ` [PATCH 19/19] mailbox: ti-msgmgr: " Thierry Reding
2018-11-28 9:39 ` [PATCH 00/19] mailbox: Device-managed registration Thierry Reding
2018-12-05 16:14 ` Thierry Reding
2018-12-07 4:09 ` Jassi Brar
2018-12-11 17:04 ` Jassi Brar
2018-12-17 14:35 ` Thierry Reding
2018-12-17 14:36 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121145429.7582-10-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).