From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74454C43441 for ; Thu, 22 Nov 2018 00:37:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 43E9A20663 for ; Thu, 22 Nov 2018 00:37:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43E9A20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391127AbeKVLOE (ORCPT ); Thu, 22 Nov 2018 06:14:04 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44942 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732226AbeKVLOD (ORCPT ); Thu, 22 Nov 2018 06:14:03 -0500 Received: from localhost.localdomain (c-24-6-170-16.hsd1.ca.comcast.net [24.6.170.16]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 87B8588D; Thu, 22 Nov 2018 00:37:13 +0000 (UTC) Date: Wed, 21 Nov 2018 16:37:11 -0800 From: Andrew Morton To: Oleg Nesterov Cc: Enke Chen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Peter Zijlstra , Arnd Bergmann , "Eric W. Biederman" , Khalid Aziz , Kate Stewart , Helge Deller , Greg Kroah-Hartman , Al Viro , Christian Brauner , Catalin Marinas , Will Deacon , Dave Martin , Mauro Carvalho Chehab , Michal Hocko , Rik van Riel , "Kirill A. Shutemov" , Roman Gushchin , Marcos Paulo de Souza , Dominik Brodowski , Cyrill Gorcunov , Yang Shi , Jann Horn , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, "Victor Kamensky (kamensky)" , xe-linux-external@cisco.com, Stefan Strogin Subject: Re: [PATCH v5] kernel/signal: Signal-based pre-coredump notification Message-Id: <20181121163711.2c00316784d221eb1750edb0@linux-foundation.org> In-Reply-To: <20181030164628.GD7643@redhat.com> References: <458c04d8-d189-4a26-729a-bb1d1d751534@cisco.com> <7741efa7-a3f8-62a1-ba52-613883164643@cisco.com> <84460a77-a111-404e-4bad-88104a6e246e@cisco.com> <20181026082812.GA10581@redhat.com> <21f678a8-4001-df36-c26e-e96cf203b1b1@cisco.com> <20181029111804.GA24820@redhat.com> <0c197608-3b7e-ffd1-8943-801a60beb917@cisco.com> <20181030164628.GD7643@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Oct 2018 17:46:29 +0100 Oleg Nesterov wrote: > On 10/29, Enke Chen wrote: > > > > Reviewed-by: Oleg Nesterov > > Hmm. I didn't say this ;) > > But OK, feel free to keep this tag. > > I do not like this feauture. Why is that? > But I see no technical problems in this version > and I never pretented I understand the user-space needs, so I won't argue. The changelog appears to spell this all out quite well? Unusually well, in my experience ;) A couple of things... - We'll be looking for a manpage update please. (Search MAINTAINERS for "manpage") - As it's a linux-specific feature, a test under tools/testing/selftests would be appropriate. I don't know how much that work will be. Do we have other linux-specific signal extensions which could piggyback onto that?