From: "Serge E. Hallyn" <serge@hallyn.com>
To: Tycho Andersen <tycho@tycho.ws>
Cc: Christian Brauner <christian@brauner.io>,
ebiederm@xmission.com, linux-kernel@vger.kernel.org,
serge@hallyn.com, jannh@google.com, luto@kernel.org,
akpm@linux-foundation.org, oleg@redhat.com, cyphar@cyphar.com,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-api@vger.kernel.org, dancol@google.com,
timmurray@google.com, linux-man@vger.kernel.org,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v1 2/2] signal: add procfd_signal() syscall
Date: Thu, 22 Nov 2018 01:48:07 -0600 [thread overview]
Message-ID: <20181122074807.GB15484@mail.hallyn.com> (raw)
In-Reply-To: <20181119223954.GA4992@cisco>
On Mon, Nov 19, 2018 at 03:39:54PM -0700, Tycho Andersen wrote:
> On Mon, Nov 19, 2018 at 11:32:39AM +0100, Christian Brauner wrote:
> >
> > +/**
> > + * sys_procfd_signal - send a signal to a process through a process file
> > + * descriptor
> > + * @fd: the file descriptor of the process
> > + * @sig: signal to be sent
> > + * @info: the signal info
> > + * @flags: future flags to be passed
> > + */
> > +SYSCALL_DEFINE4(procfd_signal, int, fd, int, sig, siginfo_t __user *, info,
> > + int, flags)
> > +{
>
> Can I just register an objection here that I think using a syscall
> just for this is silly?
>
> My understanding is that the concern is that some code might do:
>
> unknown_fd = recv_fd();
> ioctl(unknown_fd, SOME_IOCTL, NULL); // where SOME_IOCTL == PROC_FD_KILL
> // whoops, unknown_fd was a procfd and we killed a task!
This could just be my own mental model, but for something like "kill a
task", an ioctl just seems wrong. Syscall seems more natural.
I'd ack either method.
-serge
next prev parent reply other threads:[~2018-11-22 7:48 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 10:32 [PATCH v1 0/2] proc: allow signaling processes via file descriptors Christian Brauner
2018-11-19 10:32 ` [PATCH v1 1/2] proc: get process file descriptor from /proc/<pid> Christian Brauner
2018-11-19 15:32 ` Andy Lutomirski
2018-11-19 18:20 ` Christian Brauner
2018-11-19 10:32 ` [PATCH v1 2/2] signal: add procfd_signal() syscall Christian Brauner
2018-11-19 15:45 ` Andy Lutomirski
2018-11-19 15:57 ` Daniel Colascione
2018-11-19 18:39 ` Christian Brauner
2018-11-19 15:59 ` Daniel Colascione
2018-11-19 18:29 ` Christian Brauner
2018-11-19 19:02 ` Eric W. Biederman
2018-11-19 19:31 ` Christian Brauner
2018-11-19 19:39 ` Daniel Colascione
2018-11-19 17:10 ` Eugene Syromiatnikov
2018-11-19 18:23 ` Christian Brauner
2018-11-19 17:14 ` Eugene Syromiatnikov
2018-11-19 20:28 ` Aleksa Sarai
2018-11-19 20:55 ` Christian Brauner
2018-11-19 21:13 ` Christian Brauner
2018-11-19 21:18 ` Aleksa Sarai
2018-11-19 21:20 ` Christian Brauner
2018-11-19 21:21 ` Christian Brauner
2018-11-19 21:25 ` Aleksa Sarai
2018-11-19 21:26 ` Daniel Colascione
2018-11-19 21:36 ` Aleksa Sarai
2018-11-19 21:37 ` Christian Brauner
2018-11-19 21:41 ` Daniel Colascione
2018-11-20 4:59 ` Eric W. Biederman
2018-11-20 10:31 ` Christian Brauner
2018-11-21 21:39 ` Serge E. Hallyn
2018-11-19 21:23 ` Aleksa Sarai
2018-11-22 7:41 ` Serge E. Hallyn
2018-11-19 22:39 ` Tycho Andersen
2018-11-19 22:49 ` Daniel Colascione
2018-11-19 23:07 ` Tycho Andersen
2018-11-20 0:27 ` Andy Lutomirski
2018-11-20 0:32 ` Christian Brauner
2018-11-20 0:34 ` Andy Lutomirski
2018-11-20 0:49 ` Daniel Colascione
2018-11-22 7:48 ` Serge E. Hallyn [this message]
2018-11-19 23:35 ` kbuild test robot
2018-11-19 23:37 ` kbuild test robot
2018-11-19 23:45 ` Christian Brauner
2018-11-28 21:45 ` Joey Pabalinas
2018-11-28 22:05 ` Christian Brauner
2018-11-28 23:02 ` Joey Pabalinas
2018-11-19 10:32 ` [PATCH] procfd_signal.2: document procfd_signal syscall Christian Brauner
2018-11-20 13:29 ` Michael Kerrisk (man-pages)
2018-11-28 20:59 ` Florian Weimer
2018-11-28 21:12 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181122074807.GB15484@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=akpm@linux-foundation.org \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=dancol@google.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=timmurray@google.com \
--cc=tycho@tycho.ws \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).