From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32C24C43441 for ; Fri, 23 Nov 2018 08:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0625920861 for ; Fri, 23 Nov 2018 08:47:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0625920861 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502282AbeKWTa2 (ORCPT ); Fri, 23 Nov 2018 14:30:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:59286 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387605AbeKWTa2 (ORCPT ); Fri, 23 Nov 2018 14:30:28 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A1F64ABCE; Fri, 23 Nov 2018 08:47:09 +0000 (UTC) Date: Fri, 23 Nov 2018 09:47:09 +0100 From: Michal Hocko To: Christoph Hellwig Cc: Dan Williams , akpm@linux-foundation.org, =?iso-8859-1?B?Suly9G1l?= Glisse , torvalds@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v8 1/7] mm, devm_memremap_pages: Mark devm_memremap_pages() EXPORT_SYMBOL_GPL Message-ID: <20181123084709.GB8625@dhcp22.suse.cz> References: <154275556908.76910.8966087090637564219.stgit@dwillia2-desk3.amr.corp.intel.com> <154275557457.76910.16923571232582744134.stgit@dwillia2-desk3.amr.corp.intel.com> <20181122133013.GG18011@dhcp22.suse.cz> <20181122163858.GA23809@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181122163858.GA23809@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 22-11-18 17:38:58, Christoph Hellwig wrote: > On Thu, Nov 22, 2018 at 02:30:13PM +0100, Michal Hocko wrote: > > Whoever needs a wrapper around arch_add_memory can do so because this > > symbol has no restriction for the usage. > > arch_add_memory is not exported, and it really should not be. It is not, but nobody really prevents from wrapping it and exporting. I am definitely not arguing for that and I would even agree with you that it shouldn't be exported at all unless there is a _very_ good reason for that. Because usecases is what we care about here. -- Michal Hocko SUSE Labs