From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Subject: Re: [RESEND PATCH v3 2/2] PCI: uniphier: Add UniPhier PCIe host controller support
Date: Fri, 23 Nov 2018 17:50:20 +0000 [thread overview]
Message-ID: <20181123174754.GA9772@e107981-ln.cambridge.arm.com> (raw)
In-Reply-To: <20181120211531.3607.4A936039@socionext.com>
On Tue, Nov 20, 2018 at 09:15:31PM +0900, Kunihiko Hayashi wrote:
[...]
> > > +static int uniphier_pcie_link_up(struct dw_pcie *pci)
> >
> > This function returns a bool value, make it return a bool.
>
> This function is registered in struct dw_pcie_ops.link_up, that is defined
> in pcie-designware.h as follows:
>
> int (*link_up)(struct dw_pcie *pcie);
>
> Changing the return type of this function makes type mismatch,
> so I think it's difficult to change it.
You are right, it is fine.
Thanks,
Lorenzo
prev parent reply other threads:[~2018-11-23 17:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 5:27 [RESEND PATCH v3 0/2] add new UniPhier PCIe host driver Kunihiko Hayashi
2018-10-16 5:27 ` [RESEND PATCH v3 1/2] dt-bindings: PCI: Add UniPhier PCIe host controller description Kunihiko Hayashi
2018-11-19 11:40 ` Lorenzo Pieralisi
2018-11-20 12:15 ` Kunihiko Hayashi
2018-10-16 5:27 ` [RESEND PATCH v3 2/2] PCI: uniphier: Add UniPhier PCIe host controller support Kunihiko Hayashi
2018-11-19 16:17 ` Lorenzo Pieralisi
2018-11-20 12:15 ` Kunihiko Hayashi
2018-11-23 17:50 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123174754.GA9772@e107981-ln.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masami.hiramatsu@linaro.org \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).