From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3B0DC43441 for ; Fri, 23 Nov 2018 20:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 860E720685 for ; Fri, 23 Nov 2018 20:41:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HY7Dx1Da" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 860E720685 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726234AbeKXH1W (ORCPT ); Sat, 24 Nov 2018 02:27:22 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38372 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725959AbeKXH1O (ORCPT ); Sat, 24 Nov 2018 02:27:14 -0500 Received: by mail-wm1-f68.google.com with SMTP id k198so13067483wmd.3 for ; Fri, 23 Nov 2018 12:41:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wfbpFWl5GpYveIHjj2TSl8HmA16Uk7z5IJusQKFHpFc=; b=HY7Dx1DaLKFEr4fQ0ntznv4jtOeaMA71dgwKohgM+w1PJoSzOyxjppUArmOenm4GBZ 0DWWt48+DTwjdwbPwYwKIvPESkmT3ZtZlDuOe99hODNQiId6FC4f6vFqijB3sBSzK+ff RKyh5dtikaZCY1wvwHhl217k8ly2FHeXTZkck4hI52i3okj7OUbGwC3f8qtTeIf6qtaF dk+eINoj3orpQr6167b6xGGxp+l3hpUzEA9zdZoXvSUvIhJQfgiUmkSiKnTd+2oajanh qsqXxNAH30dhDkVnpDM9TO4ezYvBSEsXQGQrgceoLl9Tpa5+Ia0NGiA687nZduAWCGQv sJew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wfbpFWl5GpYveIHjj2TSl8HmA16Uk7z5IJusQKFHpFc=; b=alatzbHLiXLK0t7Unpc+I2fWOEt0IINyWH66u+yDV9/C2evKsaZRxcgJcbU9oFeyzD jG3Y6xvhxUGSR3nCMCFLQsbfHs7HCQq9+aijYew7eSi3vY+fF2MROu5SIBtbXJf+yeUc 2cODPyD+F3/3s2Akr7b8CbGDsvJ7IyRZJaymk2cARw9afBcsKuS2EndTWgh0BtjYYHGq LkxNsPwPxpAOLRa6IJ6GQ8ji38fi2RtpQDHChLuHw6LiVdQ9IKw1kFk21wlLaO0Ilowp jYLAg7nag3DJu/vocyWlMRRAypkV7zMKUSbsmFTUMRFcby3zLQZZ3JrZ3e6/D5u3rjY4 eB7w== X-Gm-Message-State: AGRZ1gK/LlEfJINhm9xJ9gHndg3fFW/tIqfbQTaDJ+g3vkfQtK/NxgU6 enuRXt3rRknzilzbtBejlc4= X-Google-Smtp-Source: AJdET5dW7RDCjT8S7rDg+RXDPo9W7OX+h2Fav7na9qYVKA85KC0xxz4UThNoL99I2OFSRECZ2MwxIg== X-Received: by 2002:a1c:9a4c:: with SMTP id c73mr15737021wme.35.1543005683215; Fri, 23 Nov 2018 12:41:23 -0800 (PST) Received: from localhost.localdomain ([2a02:8108:85c0:3a84:1919:ecb4:15a4:d6ba]) by smtp.gmail.com with ESMTPSA id i9sm24598906wrs.34.2018.11.23.12.41.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Nov 2018 12:41:22 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 6/9] staging: rtl8188eu: refactor if else statement Date: Fri, 23 Nov 2018 21:41:03 +0100 Message-Id: <20181123204106.2284-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181123204106.2284-1-straube.linux@gmail.com> References: <20181123204106.2284-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Refactor if else statement to clear checkpatch warnings. WARNING: else is not generally useful after a break or return WARNING: line over 80 characters Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme.c b/drivers/staging/rtl8188eu/core/rtw_mlme.c index 9cc7d5b8293c..513b6d89a0de 100644 --- a/drivers/staging/rtl8188eu/core/rtw_mlme.c +++ b/drivers/staging/rtl8188eu/core/rtw_mlme.c @@ -1758,12 +1758,9 @@ int rtw_restruct_sec_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ } iEntry = SecIsInPMKIDList(adapter, pmlmepriv->assoc_bssid); - if (iEntry < 0) { - return ielength; - } else { - if (authmode == _WPA2_IE_ID_) - ielength = rtw_append_pmkid(adapter, iEntry, out_ie, ielength); - } + if (iEntry >= 0 && authmode == _WPA2_IE_ID_) + ielength = rtw_append_pmkid(adapter, iEntry, out_ie, ielength); + return ielength; } -- 2.19.2