From: Helen Koike <helen.koike@collabora.com>
To: David Airlie <airlied@linux.ie>
Cc: dnicoara@chromium.org, alexandros.frantzis@collabora.com,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Gustavo Padovan" <gustavo.padovan@collabora.com>,
"tomasz Figa" <tfiga@chromium.org>,
"Sean Paul" <seanpaul@google.com>,
kernel@collabora.com, "Stéphane Marchesin" <marcheu@google.com>
Subject: [PATCH] drm: add capability DRM_CAP_ASYNC_UPDATE
Date: Fri, 23 Nov 2018 19:53:26 -0200 [thread overview]
Message-ID: <20181123215326.14274-1-helen.koike@collabora.com> (raw)
Allow userspace to identify if the driver supports async update.
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
[prepared for upstream]
Signed-off-by: Helen Koike <helen.koike@collabora.com>
---
Hi,
This patch introduces the ASYNC_UPDATE cap, which originated from the
discussion regarding DRM_MODE_ATOMIC_AMEND on [1], to allow user to
figure that async_update exists.
This was tested using a small program that exercises the uAPI for easy
sanity testing. The program was created by Alexandros and modified by
Enric to test the capability flag [2].
The test worked on a rockchip Ficus v1.1 board on top of mainline plus
the patch to update cursors asynchronously through atomic plus the patch
that introduces the ATOMIC_AMEND flag for the drm/rockchip driver.
To test, just build the program and use the --atomic flag to use the cursor
plane with the ATOMIC_AMEND flag. E.g.
drm_cursor --atomic
[1] https://patchwork.freedesktop.org/patch/243088/
[2] https://gitlab.collabora.com/eballetbo/drm-cursor/commits/async-capability
Thanks
Helen
drivers/gpu/drm/drm_ioctl.c | 11 +++++++++++
include/uapi/drm/drm.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c
index 94bd872d56c4..4a7e0f874171 100644
--- a/drivers/gpu/drm/drm_ioctl.c
+++ b/drivers/gpu/drm/drm_ioctl.c
@@ -31,6 +31,7 @@
#include <drm/drm_ioctl.h>
#include <drm/drmP.h>
#include <drm/drm_auth.h>
+#include <drm/drm_modeset_helper_vtables.h>
#include "drm_legacy.h"
#include "drm_internal.h"
#include "drm_crtc_internal.h"
@@ -229,6 +230,7 @@ static int drm_getcap(struct drm_device *dev, void *data, struct drm_file *file_
{
struct drm_get_cap *req = data;
struct drm_crtc *crtc;
+ struct drm_plane *plane;
req->value = 0;
@@ -292,6 +294,15 @@ static int drm_getcap(struct drm_device *dev, void *data, struct drm_file *file_
case DRM_CAP_CRTC_IN_VBLANK_EVENT:
req->value = 1;
break;
+ case DRM_CAP_ASYNC_UPDATE:
+ req->value = 1;
+ list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
+ if (!plane->helper_private->atomic_async_update) {
+ req->value = 0;
+ break;
+ }
+ }
+ break;
default:
return -EINVAL;
}
diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h
index 300f336633f2..ff01540cbb1d 100644
--- a/include/uapi/drm/drm.h
+++ b/include/uapi/drm/drm.h
@@ -649,6 +649,7 @@ struct drm_gem_open {
#define DRM_CAP_PAGE_FLIP_TARGET 0x11
#define DRM_CAP_CRTC_IN_VBLANK_EVENT 0x12
#define DRM_CAP_SYNCOBJ 0x13
+#define DRM_CAP_ASYNC_UPDATE 0x14
/** DRM_IOCTL_GET_CAP ioctl argument type */
struct drm_get_cap {
--
2.19.1
next reply other threads:[~2018-11-23 21:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 21:53 Helen Koike [this message]
2018-11-27 13:34 ` [PATCH] drm: add capability DRM_CAP_ASYNC_UPDATE Ville Syrjälä
2018-12-05 16:12 ` Helen Koike
2018-12-13 4:02 ` Tomasz Figa
2018-12-14 1:35 ` Helen Koike
2018-12-20 9:07 ` Tomasz Figa
2018-12-20 10:47 ` Daniel Vetter
2018-12-20 16:40 ` Alex Deucher
2018-12-20 16:54 ` Daniel Vetter
2018-12-20 17:03 ` Alex Deucher
2018-12-20 17:09 ` Daniel Vetter
2018-12-20 17:16 ` Michel Dänzer
2018-12-20 17:24 ` Daniel Vetter
2018-12-21 9:47 ` Michel Dänzer
2018-12-21 13:26 ` Daniel Vetter
2018-12-21 15:51 ` Michel Dänzer
2018-12-20 17:38 ` Kazlauskas, Nicholas
2018-12-20 18:34 ` Daniel Vetter
2018-12-21 9:55 ` Michel Dänzer
2018-12-21 3:51 ` Tomasz Figa
2018-12-21 13:42 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123215326.14274-1-helen.koike@collabora.com \
--to=helen.koike@collabora.com \
--cc=airlied@linux.ie \
--cc=alexandros.frantzis@collabora.com \
--cc=dnicoara@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcheu@google.com \
--cc=seanpaul@google.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).