From: PanBian <bianpan2016@163.com>
To: Viacheslav Dubeyko <slava@dubeyko.com>
Cc: "Joe Perches" <joe@perches.com>,
"Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hfs: do not free node before using
Date: Sat, 24 Nov 2018 09:54:23 +0800 [thread overview]
Message-ID: <20181124015423.GB23256@bp> (raw)
In-Reply-To: <1543020709.12764.3.camel@dubeyko.com>
On Fri, Nov 23, 2018 at 04:51:49PM -0800, Viacheslav Dubeyko wrote:
> On Fri, 2018-11-23 at 17:04 +0800, Pan Bian wrote:
> > The function hfs_bmap_free frees node via hfs_bnode_put(node).
> > However,
> > it then reads node->this when dumping error message on an error path,
> > which may result in a use-after-free bug. This patch frees node only
> > when it is never used.
> >
> > Fixes: d614267329f("hfs/hfsplus: convert printks to pr_<level>")
> >
> > Signed-off-by: Pan Bian <bianpan2016@163.com>
> > ---
> > fs/hfs/btree.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/hfs/btree.c b/fs/hfs/btree.c
> > index 98b96ff..19017d2 100644
> > --- a/fs/hfs/btree.c
> > +++ b/fs/hfs/btree.c
> > @@ -338,13 +338,14 @@ void hfs_bmap_free(struct hfs_bnode *node)
> >
> > nidx -= len * 8;
> > i = node->next;
> > - hfs_bnode_put(node);
> > if (!i) {
> > /* panic */;
> > pr_crit("unable to free bnode %u. bmap not
> > found!\n",
> > node->this);
>
>
> What's about simply to store node->this into the local variable in the
> beginning of the cycle? In this case, it is possible to use the node ID
> in the pr_crit() and to use the hfs_bnode_put(node) in the same place
> without to use it twice. What do you think?
Of course, it is a solution. But I think doing like that does not really
simplify the code, as we have to declare an extra local variable, and
assign node->this to it...
Best,
Pan
>
> Thanks,
> Vyacheslav Dubeyko.
>
>
> > + hfs_bnode_put(node);
> > return;
> > }
> > + hfs_bnode_put(node);
> > node = hfs_bnode_find(tree, i);
> > if (IS_ERR(node))
> > return;
prev parent reply other threads:[~2018-11-24 1:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 9:04 [PATCH] hfs: do not free node before using Pan Bian
2018-11-23 12:59 ` Joe Perches
2018-11-24 0:51 ` Viacheslav Dubeyko
2018-11-24 1:54 ` PanBian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181124015423.GB23256@bp \
--to=bianpan2016@163.com \
--cc=akpm@linux-foundation.org \
--cc=ernesto.mnd.fernandez@gmail.com \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).