From: Pavel Machek <pavel@ucw.cz>
To: Ayman Bagabas <ayman.bagabas@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/3] x86: add support for Huawei WMI hotkeys.
Date: Sun, 25 Nov 2018 10:38:25 +0100 [thread overview]
Message-ID: <20181125093825.GA24150@amd> (raw)
In-Reply-To: <20181031191938.7513-1-ayman.bagabas@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]
On Wed 2018-10-31 15:19:36, Ayman Bagabas wrote:
> This driver adds support for missing hotkeys on some Huawei laptops.
> Currently, only Huawei Matebook X Pro is supported. The driver
> recognizes the following keys: brightness keys, micmute, wlan, and
> Huawei special key. The brightness keys are ignored since they work out
> of the box.
>
> Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
> ---
> drivers/platform/x86/Kconfig | 13 ++
> drivers/platform/x86/Makefile | 1 +
> drivers/platform/x86/huawei_wmi.c | 225 ++++++++++++++++++++++++++++++
> 3 files changed, 239 insertions(+)
> create mode 100644 drivers/platform/x86/huawei_wmi.c
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 0c1aa6c314f5..c6813981e45c 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1229,6 +1229,19 @@ config I2C_MULTI_INSTANTIATE
> To compile this driver as a module, choose M here: the module
> will be called i2c-multi-instantiate.
>
> +config HUAWEI_LAPTOP
> + tristate "Huawei WMI hotkeys driver"
> + depends on ACPI
> + depends on ACPI_WMI
> + depends on INPUT
> + select INPUT_SPARSEKMAP
> + help
> + This driver provides support for Huawei WMI hotkeys.
> + It enables the missing keys and adds support to micmute
> + led found on these laptops.q
> + Supported devices are:
> + - Matebook X Pro
Extra q. Plus we normally say module name in Kconfig help text. See
above.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2018-11-25 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 19:19 [PATCH 1/3] x86: add support for Huawei WMI hotkeys Ayman Bagabas
2018-11-25 9:38 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181125093825.GA24150@amd \
--to=pavel@ucw.cz \
--cc=andy@infradead.org \
--cc=ayman.bagabas@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).