From: Sahitya Tummala <stummala@codeaurora.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: fix to allow node segment for GC by ioctl path
Date: Mon, 26 Nov 2018 09:59:03 +0530 [thread overview]
Message-ID: <20181126042903.GD9838@codeaurora.org> (raw)
In-Reply-To: <f94e8b8c-0c20-0668-16ad-4978b0600d36@huawei.com>
On Sat, Nov 24, 2018 at 06:23:55PM +0800, Chao Yu wrote:
> On 2018/11/23 13:12, Sahitya Tummala wrote:
> > Allow node type segments also to be GC'd via f2fs ioctls
> > F2FS_IOC_GARBAGE_COLLECT and F2FS_IOC_GARBAGE_COLLECT_RANGE.
>
> IIRC, only F2FS_IOC_GARBAGE_COLLECT_RANGE pass a valid segment number via
> @result parameter in get_victim_by_default(), so in commit message, it
> needs to remove F2FS_IOC_GARBAGE_COLLECT, right?
>
Yes Chao, my mistake. Thanks for pointing it out. I will update it
and send the patch for review.
> Thanks,
>
> >
> > Signed-off-by: Sahitya Tummala <stummala@codeaurora.org>
> > ---
> > fs/f2fs/gc.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> > index a07241f..e4689c6 100644
> > --- a/fs/f2fs/gc.c
> > +++ b/fs/f2fs/gc.c
> > @@ -323,8 +323,7 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi,
> > p.min_cost = get_max_cost(sbi, &p);
> >
> > if (*result != NULL_SEGNO) {
> > - if (IS_DATASEG(get_seg_entry(sbi, *result)->type) &&
> > - get_valid_blocks(sbi, *result, false) &&
> > + if (get_valid_blocks(sbi, *result, false) &&
> > !sec_usage_check(sbi, GET_SEC_FROM_SEG(sbi, *result)))
> > p.min_segno = *result;
> > goto out;
> > @@ -404,11 +403,12 @@ static int get_victim_by_default(struct f2fs_sb_info *sbi,
> > }
> > *result = (p.min_segno / p.ofs_unit) * p.ofs_unit;
> >
> > + }
> > +out:
> > + if (p.min_segno != NULL_SEGNO)
> > trace_f2fs_get_victim(sbi->sb, type, gc_type, &p,
> > sbi->cur_victim_sec,
> > prefree_segments(sbi), free_segments(sbi));
> > - }
> > -out:
> > mutex_unlock(&dirty_i->seglist_lock);
> >
> > return (p.min_segno == NULL_SEGNO) ? 0 : 1;
> >
>
--
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
prev parent reply other threads:[~2018-11-26 4:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 5:12 [PATCH] f2fs: fix to allow node segment for GC by ioctl path Sahitya Tummala
2018-11-24 10:23 ` Chao Yu
2018-11-26 4:29 ` Sahitya Tummala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126042903.GD9838@codeaurora.org \
--to=stummala@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).