From: Christoph Hellwig <hch@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
Robin Murphy <robin.murphy@arm.com>,
Matthew Wilcox <willy@infradead.org>,
Christopher Lameter <cl@linux.com>,
Levin Alexander <Alexander.Levin@microsoft.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Nicolas Boichat <drinkcat@chromium.org>,
Huaisheng Ye <yehs1@lenovo.com>, Tomasz Figa <tfiga@google.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, iommu@lists.linux-foundation.org,
Michal Hocko <mhocko@suse.com>,
linux-arm-kernel@lists.infradead.org,
David Rientjes <rientjes@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
yingjoe.chen@mediatek.com, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Mel Gorman <mgorman@techsingularity.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 0/3] iommu/io-pgtable-arm-v7s: Use DMA32 zone for page tables
Date: Mon, 26 Nov 2018 00:02:13 -0800 [thread overview]
Message-ID: <20181126080213.GA17809@infradead.org> (raw)
In-Reply-To: <555dd63a-0634-6a39-7abc-121e02273cb2@suse.cz>
On Fri, Nov 23, 2018 at 01:23:41PM +0100, Vlastimil Babka wrote:
> Is this also true for caches created by kmem_cache_create(), that
> debugging options can result in not respecting the alignment passed to
> kmem_cache_create()? That would be rather bad, IMHO.
That's what I understood in the discussion. If not it would make
our live simpler, but would need to be well document.
Christoph can probably explain the alignment choices in slub.
>
> > But I do agree with the sentiment of not wanting to spread GFP_DMA32
> > futher into the slab allocator.
>
> I don't see a problem with GFP_DMA32 for custom caches. Generic
> kmalloc() would be worse, since it would have to create a new array of
> kmalloc caches. But that's already ruled out due to the alignment.
True, purely slab probably isn't too bad.
next prev parent reply other threads:[~2018-11-26 8:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 9:03 [PATCH v2 0/3] iommu/io-pgtable-arm-v7s: Use DMA32 zone for page tables Nicolas Boichat
2018-11-11 9:03 ` [PATCH v2 1/3] mm: slab/slub: Add check_slab_flags function to check for valid flags Nicolas Boichat
2018-11-11 9:03 ` [PATCH v2 2/3] mm: Add support for SLAB_CACHE_DMA32 Nicolas Boichat
2018-11-21 18:32 ` Christopher Lameter
2018-11-22 0:52 ` Nicolas Boichat
2018-11-11 9:03 ` [PATCH v2 3/3] iommu/io-pgtable-arm-v7s: Request DMA32 memory, and improve debugging Nicolas Boichat
2018-11-21 16:46 ` Will Deacon
2018-11-21 17:38 ` Christopher Lameter
2018-11-21 17:43 ` Robin Murphy
2018-11-21 18:18 ` Christopher Lameter
2018-11-21 18:02 ` Michal Hocko
2018-11-22 1:20 ` Nicolas Boichat
2018-11-23 12:15 ` Vlastimil Babka
2018-11-21 18:20 ` [PATCH v2 0/3] iommu/io-pgtable-arm-v7s: Use DMA32 zone for page tables Christopher Lameter
2018-11-21 21:38 ` Matthew Wilcox
2018-11-21 22:26 ` Robin Murphy
2018-11-22 1:05 ` Nicolas Boichat
2018-11-22 2:35 ` Matthew Wilcox
2018-11-22 5:56 ` Nicolas Boichat
2018-11-22 8:26 ` Christoph Hellwig
2018-11-22 15:16 ` Matthew Wilcox
2018-11-22 15:19 ` Christoph Hellwig
2018-11-22 8:23 ` Christoph Hellwig
2018-11-23 3:04 ` Nicolas Boichat
2018-11-23 5:37 ` Nicolas Boichat
2018-11-23 12:23 ` Vlastimil Babka
2018-11-23 12:30 ` Michal Hocko
2018-11-26 8:02 ` Christoph Hellwig [this message]
2018-11-28 8:55 ` Nicolas Boichat
2018-12-04 9:37 ` Nicolas Boichat
2018-12-04 14:35 ` Vlastimil Babka
2018-12-05 2:04 ` Nicolas Boichat
2018-12-05 5:51 ` Nicolas Boichat
2018-12-05 14:41 ` Will Deacon
2018-12-04 16:28 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126080213.GA17809@infradead.org \
--to=hch@infradead.org \
--cc=Alexander.Levin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=drinkcat@chromium.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=tfiga@google.com \
--cc=vbabka@suse.cz \
--cc=will.deacon@arm.com \
--cc=willy@infradead.org \
--cc=yehs1@lenovo.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).