* [PATCH 1/2] i3c: fix an error code in i3c_master_add_i3c_dev_locked()
@ 2018-11-23 7:14 Dan Carpenter
2018-11-26 8:46 ` Boris Brezillon
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-11-23 7:14 UTC (permalink / raw)
To: Boris Brezillon; +Cc: linux-kernel, kernel-janitors
We should return "ret" as-is. The "newdev" variable is a valid pointer.
Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/i3c/master.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 0ea7bb045fad..bda4b9613e53 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -1823,10 +1823,8 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master,
return PTR_ERR(newdev);
ret = i3c_master_attach_i3c_dev(master, newdev);
- if (ret) {
- ret = PTR_ERR(newdev);
+ if (ret)
goto err_free_dev;
- }
ret = i3c_master_retrieve_dev_info(newdev);
if (ret)
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] i3c: fix an error code in i3c_master_add_i3c_dev_locked()
2018-11-23 7:14 [PATCH 1/2] i3c: fix an error code in i3c_master_add_i3c_dev_locked() Dan Carpenter
@ 2018-11-26 8:46 ` Boris Brezillon
0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2018-11-26 8:46 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, kernel-janitors
On Fri, 23 Nov 2018 10:14:42 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We should return "ret" as-is. The "newdev" variable is a valid pointer.
>
> Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Queued to i3c/next.
Thanks,
Boris
> ---
> drivers/i3c/master.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 0ea7bb045fad..bda4b9613e53 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -1823,10 +1823,8 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master,
> return PTR_ERR(newdev);
>
> ret = i3c_master_attach_i3c_dev(master, newdev);
> - if (ret) {
> - ret = PTR_ERR(newdev);
> + if (ret)
> goto err_free_dev;
> - }
>
> ret = i3c_master_retrieve_dev_info(newdev);
> if (ret)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-26 8:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-23 7:14 [PATCH 1/2] i3c: fix an error code in i3c_master_add_i3c_dev_locked() Dan Carpenter
2018-11-26 8:46 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).