From: Viresh Kumar <viresh.kumar@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Quentin Perret <quentin.perret@linaro.org>,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
Chris Redpath <chris.redpath@linaro.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
Nicolas Dechesne <nicolas.dechesne@linaro.org>,
Niklas Cassel <niklas.cassel@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH V3 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT
Date: Mon, 26 Nov 2018 15:49:55 +0530 [thread overview]
Message-ID: <20181126101955.pdn76f2ujeb6urxz@vireshk-i7> (raw)
In-Reply-To: <97f85a4b-efb6-b26f-94d0-cd538c83a03e@linaro.org>
On 26-11-18, 11:08, Daniel Lezcano wrote:
> On 26/11/2018 10:52, Quentin Perret wrote:
> > Maybe you want to test 'if (!raw_capacity || cap_parsing_failed)' at the
> > top of topology_parse_cpu_capacity() ?
>
> I prefer to update the documentation, it makes more sense than adding
> more cumbersome tests in the current code.
+1
Throwing an error and ignoring DT number completely for the capacity
are good enough in my opinion as well.
And who cares for the platforms that can't even fill the DT properly :)
--
viresh
next prev parent reply other threads:[~2018-11-26 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 8:44 [PATCH V3 1/2] base/drivers/arch_topology: Replace mutex with READ_ONCE / WRITE_ONCE Daniel Lezcano
2018-11-26 8:44 ` [PATCH V3 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT Daniel Lezcano
2018-11-26 8:45 ` Viresh Kumar
2018-11-26 9:52 ` Quentin Perret
2018-11-26 10:08 ` Daniel Lezcano
2018-11-26 10:19 ` Viresh Kumar [this message]
2018-11-26 11:09 ` Quentin Perret
2018-11-26 11:36 ` Daniel Lezcano
2018-11-26 12:15 ` Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126101955.pdn76f2ujeb6urxz@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=chris.redpath@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.dechesne@linaro.org \
--cc=niklas.cassel@linaro.org \
--cc=quentin.perret@linaro.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).