From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Steve French <smfrench@gmail.com>
Cc: Sachin Prabhu <sprabhu@redhat.com>,
CIFS <linux-cifs@vger.kernel.org>,
keescook@google.com,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warnings after merge of the cifs tree
Date: Mon, 26 Nov 2018 11:52:47 +1100 [thread overview]
Message-ID: <20181126115247.53cbf7be@canb.auug.org.au> (raw)
In-Reply-To: <CAH2r5mvtFzp=nYK+J92vh9y4tsNLT3rD4a2+mB9LMyWcFN-EHA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 668 bytes --]
Hi Steve,
On Sun, 25 Nov 2018 18:31:40 -0600 Steve French <smfrench@gmail.com> wrote:
>
> Both of those cases are intentional fallthroughs and there are
> existing comments in the code noting the reasons for them to
> fallthrough
>
> (also can see the reasoning for these in the commits which introduced
> them from Sachin c369c9a4a7c82) and dde2356c84662)
I am not questioning that :-)
The gcc warning can be turned off by adding a /* fall through */
comment at the point the fall through happens. Kees and others are
working on the several hundred other places that need annotating.
This one just popped up.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-26 0:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 0:14 linux-next: build warnings after merge of the cifs tree Stephen Rothwell
2018-11-26 0:31 ` Steve French
2018-11-26 0:52 ` Stephen Rothwell [this message]
2018-11-26 5:48 ` Kees Cook
2018-11-26 6:51 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126115247.53cbf7be@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=keescook@google.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=smfrench@gmail.com \
--cc=sprabhu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).