From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: dvhart@infradead.org, andy@infradead.org, jkosina@suse.cz,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 -next] platform/x86: intel-ips: fix 'passing zero to PTR_ERR()' warning
Date: Mon, 26 Nov 2018 15:37:57 +0200 [thread overview]
Message-ID: <20181126133757.GJ10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181126131948.18160-1-yuehaibing@huawei.com>
On Mon, Nov 26, 2018 at 09:19:48PM +0800, YueHaibing wrote:
> Fix a static code checker warning:
> drivers/platform/x86/intel_ips.c:1314
> ips_debugfs_init() warn: passing zero to 'PTR_ERR'
> drivers/platform/x86/intel_ips.c:1328
> ips_debugfs_init() warn: passing zero to 'PTR_ERR'
>
> If error occurs,debugfs_create_dir/debugfs_create_file
> return NULL while debugfs is enabled, which should not
> passing to PTR_ERR.
>
Thanks for a patch.
Though the better approach as Greg KH explained [1] is to get rid of unnecessary checks.
[1]: https://lkml.org/lkml/2015/8/15/114
> Fixes: aa7ffc01d254 ("x86 platform driver: intelligent power sharing driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2:Fix typo in patch log and title
> ---
> drivers/platform/x86/intel_ips.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index 225638a..a5d1a68 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1311,8 +1311,7 @@ static void ips_debugfs_init(struct ips_driver *ips)
>
> ips->debug_root = debugfs_create_dir("ips", NULL);
> if (!ips->debug_root) {
> - dev_err(ips->dev, "failed to create debugfs entries: %ld\n",
> - PTR_ERR(ips->debug_root));
> + dev_err(ips->dev, "failed to create debugfs entries\n")
> return;
> }
>
> @@ -1325,8 +1324,7 @@ static void ips_debugfs_init(struct ips_driver *ips)
> ips->debug_root, node,
> &ips_debugfs_ops);
> if (!ent) {
> - dev_err(ips->dev, "failed to create debug file: %ld\n",
> - PTR_ERR(ent));
> + dev_err(ips->dev, "failed to create debug file\n");
> goto err_cleanup;
> }
> }
> --
> 2.7.0
>
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-26 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 13:19 [PATCH v2 -next] platform/x86: intel-ips: fix 'passing zero to PTR_ERR()' warning YueHaibing
2018-11-26 13:37 ` Andy Shevchenko [this message]
2018-11-26 22:04 ` kbuild test robot
2018-12-02 5:01 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126133757.GJ10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).