From: Jan Kara <jack@suse.cz>
To: Colin King <colin.king@canonical.com>
Cc: Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jbd2: clean up indentation issue, replace spaces with tab
Date: Mon, 26 Nov 2018 14:56:32 +0100 [thread overview]
Message-ID: <20181126135632.GA25835@quack2.suse.cz> (raw)
In-Reply-To: <20181123164053.19193-1-colin.king@canonical.com>
On Fri 23-11-18 16:40:53, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a statement that is indented with spaces, replace it with
> a tab.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/jbd2/transaction.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index c0b66a7a795b..4af8ff17ad5c 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -910,7 +910,7 @@ do_get_write_access(handle_t *handle, struct journal_head *jh,
> * this is the first time this transaction is touching this buffer,
> * reset the modified flag
> */
> - jh->b_modified = 0;
> + jh->b_modified = 0;
>
> /*
> * If the buffer is not journaled right now, we need to make sure it
> --
> 2.19.1
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2018-11-26 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 16:40 [PATCH] jbd2: clean up indentation issue, replace spaces with tab Colin King
2018-11-26 13:56 ` Jan Kara [this message]
2018-12-04 5:21 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126135632.GA25835@quack2.suse.cz \
--to=jack@suse.cz \
--cc=colin.king@canonical.com \
--cc=jack@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).