From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381FCC43441 for ; Mon, 26 Nov 2018 16:15:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE047205C9 for ; Mon, 26 Nov 2018 16:14:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="HDOii5ER"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="KBmbS5Ts" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE047205C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726735AbeK0DJc (ORCPT ); Mon, 26 Nov 2018 22:09:32 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36542 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726206AbeK0DJb (ORCPT ); Mon, 26 Nov 2018 22:09:31 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 70BB860A9B; Mon, 26 Nov 2018 16:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1543248897; bh=VXIC4KZq0yLyhW7yK4YCjmLue8YpFs+lkfP4Sz5d6dM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HDOii5ERTog088aSdx/TR0dxWY6+I4+vlkpXbYhXafH7eWdvpwm5ZSg/Je0QTYJF8 h3tqpbbr4kBdNgii+ej2vrFl7rGh11m6bmdzm8szx1b4tlPnEWSp8Fj+qXp0AJCnXa dVTp8QKVpBFuCKikbL6/UxCWqB4A8HhO2wrayOBs= Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: ilina@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A9DDF607EB; Mon, 26 Nov 2018 16:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1543248896; bh=VXIC4KZq0yLyhW7yK4YCjmLue8YpFs+lkfP4Sz5d6dM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KBmbS5TsrrBL4XKbUSPXwZJm1jJbYVMCwwN1TvTmdNA2Mh5u/43ipF3onLiQitmF0 rNXuWkS/9gvLkV3b39VNjyEz6YosJMPaHwu17fJu7vliwCSv5M3GvqVh5vOz5H63wh 2GOZWN/B4mm3t5wMNewE05seWm5Dz1IP/ZchPxKo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A9DDF607EB Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilina@codeaurora.org Date: Mon, 26 Nov 2018 09:14:55 -0700 From: Lina Iyer To: Stephen Boyd Cc: evgreen@chromium.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, rplsssn@codeaurora.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, thierry.reding@gmail.com Subject: Re: [RFC v3 2/3] dt-bindings: sdm845-pinctrl: add wakeup interrupt parent for GPIO Message-ID: <20181126161455.GA28236@codeaurora.org> References: <20181121000648.29262-1-ilina@codeaurora.org> <20181121000648.29262-3-ilina@codeaurora.org> <154283618199.88331.10217252750356423959@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <154283618199.88331.10217252750356423959@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 21 2018 at 14:36 -0700, Stephen Boyd wrote: >Quoting Lina Iyer (2018-11-20 16:06:47) >> SDM845 SoC has an always-on interrupt controller (PDC) with select GPIO >> routed to the PDC as interrupts that can be used to wake the system up >> from deep low power modes and suspend. >> >> Signed-off-by: Lina Iyer >> --- >> .../bindings/pinctrl/qcom,sdm845-pinctrl.txt | 31 ++++++++++++++++++- >> 1 file changed, 30 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt >> index 665aadb5ea28..bedfa0b57fa6 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.txt >> @@ -29,6 +29,17 @@ SDM845 platform. >> Definition: must be 2. Specifying the pin number and flags, as defined >> in >> >> +- wakeup-parent: >> + Usage: optional >> + Value type: >> + Definition: A phandle to the wakeup interrupt controller for the SoC. >> + >> +- wakeup-irq: > >This shouldn't be needed. TLMM driver can probe for the possibility of >wakeup capable irqs from irq allocation step. The only place we should >need to know what TLMM pins map to what PDC lines is in the PDC driver. > Why? Every driver seems to translate the hardware IRQ and pass it to it's parent. Why should this be any different ? The PDC is an interrupt controller that just knows an interrupt port and maps it to the GIC. Not sure, I understand the reasoning for this. It seems to add more confusing relationship with the PDC interrupt controller, that way. -- Lina