From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel@vger.kernel.org, Leo Yan <leo.yan@linaro.org>,
David Miller <davem@davemloft.net>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH 1/5] perf tools: Add fallback functions for cases where cpumode is insufficient
Date: Mon, 26 Nov 2018 16:44:14 -0300 [thread overview]
Message-ID: <20181126194414.GF18491@kernel.org> (raw)
In-Reply-To: <20181126194145.GE18491@kernel.org>
Em Mon, Nov 26, 2018 at 04:41:45PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Nov 26, 2018 at 04:02:17PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Nov 05, 2018 at 07:53:17PM +0000, Hunter, Adrian escreveu:
> > > > From: Arnaldo Carvalho de Melo [mailto:acme@kernel.org]
> > > > Em Mon, Nov 05, 2018 at 07:21:44PM +0000, Hunter, Adrian escreveu:
> > > > > > > +static bool machine__single_ku_as(struct machine *machine) {
> > > > > > > + return strcmp(perf_env__arch(machine->env), "sparc"); }
>
> > > > > > Can we avoid having this strcmp be done repeatedly?
>
> > > > > It is only done if there are mapping errors
>
> > > > > > Can we avoid having this strcmp be done repeatedly? I.e. just
> > > > > > make this a boolean initialized at session start, when
> > > > > > machine->env is setup, so we'd have:
>
> > > > > > machine->single_address_space
>
> > > > > > Instead of a function?
>
> > > > > Sure thing.
> >
> > Have you sent an update to this patch series addressing the concerns? I
> > think that renaming that _fb to __fallback and having this
> > machine->single_address_space is what is missing, I'll try to take a
> > stab at this now and have it in my perf/core branch soon.
>
> > But you have this already done, please send it.
>
> So, here is the patch on top of yours and at the end a patch that I'm
> inserting just before yours, please check and ack, thanks:
Argh, nevermind, just saw your V2, /me goes to read it ;-\
- Arnaldo
next prev parent reply other threads:[~2018-11-27 12:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 9:10 [PATCH 0/5] perf tools: Fix for cases where cpumode is incorrect or insufficient Adrian Hunter
2018-10-31 9:10 ` [PATCH 1/5] perf tools: Add fallback functions for cases where cpumode is insufficient Adrian Hunter
2018-11-05 17:29 ` Arnaldo Carvalho de Melo
2018-11-05 18:19 ` David Miller
2018-11-05 19:21 ` Hunter, Adrian
2018-11-05 19:36 ` Arnaldo Carvalho de Melo
2018-11-05 19:53 ` Hunter, Adrian
2018-11-05 20:31 ` Arnaldo Carvalho de Melo
2018-11-26 19:02 ` Arnaldo Carvalho de Melo
2018-11-26 19:41 ` Arnaldo Carvalho de Melo
2018-11-26 19:44 ` Arnaldo Carvalho de Melo [this message]
2018-10-31 9:10 ` [PATCH 2/5] perf tools: Use fallback for sample_addr_correlates_sym() cases Adrian Hunter
2018-11-03 17:46 ` Hunter, Adrian
2018-10-31 9:10 ` [PATCH 3/5] perf tools: Use fallbacks for branch stacks Adrian Hunter
2018-11-05 17:56 ` Arnaldo Carvalho de Melo
2018-10-31 9:10 ` [PATCH 4/5] perf intel-pt: Insert callchain context into synthesized callchains Adrian Hunter
2018-10-31 13:28 ` Arnaldo Carvalho de Melo
2018-10-31 14:15 ` Adrian Hunter
2018-10-31 14:20 ` Adrian Hunter
2018-10-31 14:27 ` Arnaldo Carvalho de Melo
2018-10-31 22:12 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2018-10-31 14:26 ` [PATCH 4/5] " Arnaldo Carvalho de Melo
2018-10-31 9:10 ` [PATCH 5/5] perf intel-pt/bts: Calculate cpumode for synthesized samples Adrian Hunter
2018-10-31 22:13 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2018-10-31 13:35 ` [PATCH 0/5] perf tools: Fix for cases where cpumode is incorrect or insufficient Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181126194414.GF18491@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=davem@davemloft.net \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).