From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76CB8C43441 for ; Mon, 26 Nov 2018 22:16:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 396452082F for ; Mon, 26 Nov 2018 22:16:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20150623.gappssmtp.com header.i=@osandov-com.20150623.gappssmtp.com header.b="NB5gi8Jc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 396452082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=osandov.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727337AbeK0JLo (ORCPT ); Tue, 27 Nov 2018 04:11:44 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:39367 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726888AbeK0JLn (ORCPT ); Tue, 27 Nov 2018 04:11:43 -0500 Received: by mail-pg1-f195.google.com with SMTP id w6so6822806pgl.6 for ; Mon, 26 Nov 2018 14:16:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/6jOHBgej+zantiyYcOwKY1cQOjjygQGOg2a3ZRqxqU=; b=NB5gi8JcdVSjwscW8/Rt4u8b2kMuTzleBvZzAlQZ+T9HKueOpU3AaB85jQTJD4jk3t nHTYYAFFsNSwKzPdlToeAzO0xPvMmuFKi0bYFePZTkTtEzayyQVv/DUusQAIGgNyd0n7 vNA30QEY5zc2kZaq31CE2DT2LBjFGbEUJsrbP1okkm3x3hoAzu+oO+9/Wwhqe4srGTzc UV2lq9zpmC7DtrOQXl33VpEk0HtUWmS39A5DnUDRItubhM29fNZdPQk0idKeqtXbfQ8J NS/awNANctdAuCwkiDmLfqZZbRzXoL4a2V2cdsoi6XvOCJC5jJUSx+D/kaPEMe3EIlQn EmeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/6jOHBgej+zantiyYcOwKY1cQOjjygQGOg2a3ZRqxqU=; b=Um50wh/BgvJ2y3rU+KLM9jCbZboUnhhy1MEHCdvEV99m7TmD7VThNL3a7YdPYRFIF9 eMROiYVSLNQQFHhC3mVxdJDl55PKT3KH5qhLNZDqySGJXPj1n+oCb+dPqiv6wCGcSkBN YviAMdhOXrNgCJgK2cWz9SaxYf3GwkHgh8MndJReGKrIC+6F43kY5tD+OBFaJYSLqlYW R7UX/IbZEbM6PzWQRvVi+KpN8g5BFZZQi6dM0GQ6UzKuqXZOckSy0oAOd5KA6IG6H6WH 5BIGZhpCOlNpZQ3XxUM3zjv/eRk1dxgQtzPxwYNtpOMvMzTAQabp97gk/wxw5G/aysgY aYIg== X-Gm-Message-State: AA+aEWYALqcVy9jVK8V2jpg23D6q824O+o9JcPMOC6sU1jGbw9iESU2k cVAin2inxocryvu79RkwjIzmEA== X-Google-Smtp-Source: AFSGD/WkD2Jd+TYnAi5lcg29tMSVS++t5Jswlm8qvWgciBvd6QwP4uBQrZNdVEz5RrrM5+19nucgSA== X-Received: by 2002:a63:f658:: with SMTP id u24mr26947651pgj.267.1543270568603; Mon, 26 Nov 2018 14:16:08 -0800 (PST) Received: from vader ([2601:602:8b00:55d3:e6a7:a0ff:fe0b:c9a8]) by smtp.gmail.com with ESMTPSA id o7sm1831055pfb.34.2018.11.26.14.16.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Nov 2018 14:16:07 -0800 (PST) Date: Mon, 26 Nov 2018 14:16:06 -0800 From: Omar Sandoval To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , Omar Sandoval , Sagi Grimberg , Dave Chinner , Kent Overstreet , Mike Snitzer , dm-devel@redhat.com, Alexander Viro , linux-fsdevel@vger.kernel.org, Shaohua Li , linux-raid@vger.kernel.org, David Sterba , linux-btrfs@vger.kernel.org, "Darrick J . Wong" , linux-xfs@vger.kernel.org, Gao Xiang , Christoph Hellwig , linux-ext4@vger.kernel.org, Coly Li , linux-bcache@vger.kernel.org, Boaz Harrosh , Bob Peterson , cluster-devel@redhat.com Subject: Re: [PATCH V12 05/20] block: remove bvec_iter_rewind() Message-ID: <20181126221606.GF30411@vader> References: <20181126021720.19471-1-ming.lei@redhat.com> <20181126021720.19471-6-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181126021720.19471-6-ming.lei@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 26, 2018 at 10:17:05AM +0800, Ming Lei wrote: > Commit 7759eb23fd980 ("block: remove bio_rewind_iter()") removes > bio_rewind_iter(), then no one uses bvec_iter_rewind() any more, > so remove it. Reviewed-by: Omar Sandoval > Signed-off-by: Ming Lei > --- > include/linux/bvec.h | 24 ------------------------ > 1 file changed, 24 deletions(-) > > diff --git a/include/linux/bvec.h b/include/linux/bvec.h > index 02c73c6aa805..ba0ae40e77c9 100644 > --- a/include/linux/bvec.h > +++ b/include/linux/bvec.h > @@ -92,30 +92,6 @@ static inline bool bvec_iter_advance(const struct bio_vec *bv, > return true; > } > > -static inline bool bvec_iter_rewind(const struct bio_vec *bv, > - struct bvec_iter *iter, > - unsigned int bytes) > -{ > - while (bytes) { > - unsigned len = min(bytes, iter->bi_bvec_done); > - > - if (iter->bi_bvec_done == 0) { > - if (WARN_ONCE(iter->bi_idx == 0, > - "Attempted to rewind iter beyond " > - "bvec's boundaries\n")) { > - return false; > - } > - iter->bi_idx--; > - iter->bi_bvec_done = __bvec_iter_bvec(bv, *iter)->bv_len; > - continue; > - } > - bytes -= len; > - iter->bi_size += len; > - iter->bi_bvec_done -= len; > - } > - return true; > -} > - > #define for_each_bvec(bvl, bio_vec, iter, start) \ > for (iter = (start); \ > (iter).bi_size && \ > -- > 2.9.5 >