linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Pavan Kondeti <pkondeti@codeaurora.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched, trace: Fix prev_state output in sched_switch tracepoint
Date: Tue, 27 Nov 2018 09:29:25 -0500	[thread overview]
Message-ID: <20181127092925.46c77ae7@gandalf.local.home> (raw)
In-Reply-To: <CAEU1=PkZQGEZueS=cLOT9kbGeMBptKRL=A56BrBgG85R9PrHDA@mail.gmail.com>

On Tue, 27 Nov 2018 15:04:25 +0530
Pavan Kondeti <pkondeti@codeaurora.org> wrote:

> Hi Peter/Thomas,
> 
> On Tue, Oct 30, 2018 at 12:25 PM Pavankumar Kondeti
> <pkondeti@codeaurora.org> wrote:
> >
> > commit 3f5fe9fef5b2 ("sched/debug: Fix task state recording/printout")
> > tried to fix the problem introduced by a previous commit efb40f588b43
> > ("sched/tracing: Fix trace_sched_switch task-state printing"). However
> > the prev_state output in sched_switch is still broken.
> >
> > task_state_index() uses fls() which considers the LSB as 1. Left
> > shifting 1 by this value gives an incorrect mapping to the task state.
> > Fix this by decrementing the value returned by __get_task_state()
> > before shifting.
> >
> > Fixes: 3f5fe9fef5b2 ("sched/debug: Fix task state recording/printout")
> > Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
> > ---
> >  include/trace/events/sched.h | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)  
> 
> Can you please review this patch?
> 

I've already tested this patch. I'm working on getting other patches
upstream and this looks like it should be marked for stable. I'll take
it.

Thanks!

-- Steve

      reply	other threads:[~2018-11-27 14:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-30  6:54 [PATCH] sched, trace: Fix prev_state output in sched_switch tracepoint Pavankumar Kondeti
2018-11-27  9:34 ` Pavan Kondeti
2018-11-27 14:29   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181127092925.46c77ae7@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=pkondeti@codeaurora.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).