From: Jiri Olsa <jolsa@redhat.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Kim Phillips <kim.phillips@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Thomas Richter <tmricht@linux.ibm.com>,
rmk+kernel@armlinux.org.uk, l.stach@pengutronix.de
Subject: Re: [PATCH v2 0/2] perf tests: Check for ARM [vectors] page
Date: Tue, 27 Nov 2018 10:32:11 +0100 [thread overview]
Message-ID: <20181127093211.GD8908@krava> (raw)
In-Reply-To: <20181025175508.6967-1-f.fainelli@gmail.com>
On Thu, Oct 25, 2018 at 10:55:06AM -0700, Florian Fainelli wrote:
> Hi all,
>
> I just painfully learned that perf would segfault when
> CONFIG_KUSER_HELPERS is disabled because it unconditionally makes use of
> it. This patch series adds an ARM test for that by leveraging the
> existing find_vdso_map() function and making it more generic and capable
> of location any map within /proc/self/maps.
>
> Changes in v2:
>
> - use strlen() instead of sizeof() -1 since we made the page name a
> parameter
> - use TEST_OK/TEST_FAIL in lieu of 0/-1
> - added an error message indicating CONFIG_KUSER_HELPERS might be
> disabled
other than the function placing I mentioned in
my previous email, this seems ok to me
jirka
>
> Florian Fainelli (2):
> perf tools: Make find_vdso_map() more modular
> perf tests: Add a test for the ARM 32-bit [vectors] page
>
> tools/perf/arch/arm/tests/Build | 1 +
> tools/perf/arch/arm/tests/arch-tests.c | 4 +++
> tools/perf/arch/arm/tests/vectors-page.c | 24 ++++++++++++++++++
> tools/perf/tests/tests.h | 5 ++++
> tools/perf/util/find-map.c | 31 ++++++++++++++++++++++++
> tools/perf/util/find-vdso-map.c | 30 +++--------------------
> 6 files changed, 68 insertions(+), 27 deletions(-)
> create mode 100644 tools/perf/arch/arm/tests/vectors-page.c
> create mode 100644 tools/perf/util/find-map.c
>
> --
> 2.17.1
>
prev parent reply other threads:[~2018-11-27 9:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 17:55 Florian Fainelli
2018-10-25 17:55 ` [PATCH v2 1/2] perf tools: Make find_vdso_map() more modular Florian Fainelli
2018-11-27 9:31 ` Jiri Olsa
2018-12-10 20:16 ` Florian Fainelli
2018-11-27 9:33 ` Jiri Olsa
2018-10-25 17:55 ` [PATCH v2 2/2] perf tests: Add a test for the ARM 32-bit [vectors] page Florian Fainelli
2018-11-13 22:44 ` [PATCH v2 0/2] perf tests: Check for ARM " Florian Fainelli
2018-11-27 0:27 ` Florian Fainelli
2018-11-27 9:32 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127093211.GD8908@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kim.phillips@arm.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tglx@linutronix.de \
--cc=tmricht@linux.ibm.com \
--subject='Re: [PATCH v2 0/2] perf tests: Check for ARM [vectors] page' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).