From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Kees Cook <keescook@google.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: Re: linux-next: build warning after merge of the f2fs tree
Date: Tue, 27 Nov 2018 09:40:29 +1100 [thread overview]
Message-ID: <20181127094029.68ce2322@canb.auug.org.au> (raw)
In-Reply-To: <20181126222257.GB55960@jaegeuk-macbookpro.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]
Hi Jaegeuk,
On Mon, 26 Nov 2018 14:22:57 -0800 Jaegeuk Kim <jaegeuk@kernel.org> wrote:
>
> Is this okay?
That looks great, thanks.
> From: Jaegeuk Kim <jaegeuk@kernel.org>
> Date: Mon, 26 Nov 2018 14:20:32 -0800
> Subject: [PATCH] f2fs: avoid build warn of fall_through
>
> After merging the f2fs tree, today's linux-next build
> (x86_64_allmodconfig) produced this warning:
>
> In file included from fs/f2fs/dir.c:11:
> fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
> fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (set)
> ^
> fs/f2fs/f2fs.h:2390:2: note: here
> case FI_DATA_EXIST:
> ^~~~
>
> Exposed by my use of -Wimplicit-fallthrough
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/f2fs.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 26ad1de8641c..b3fe6803d4c6 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -2387,6 +2387,7 @@ static inline void __mark_inode_dirty_flag(struct inode *inode,
> case FI_NEW_INODE:
> if (set)
> return;
> + /* fall through */
> case FI_DATA_EXIST:
> case FI_INLINE_DOTS:
> case FI_PIN_FILE:
> --
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-26 22:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 0:19 linux-next: build warning after merge of the f2fs tree Stephen Rothwell
2018-11-26 21:59 ` Jaegeuk Kim
2018-11-26 22:17 ` Stephen Rothwell
2018-11-26 22:22 ` Jaegeuk Kim
2018-11-26 22:36 ` Gustavo A. R. Silva
2018-11-26 22:40 ` Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-02 22:23 Stephen Rothwell
2021-03-03 19:27 ` Jaegeuk Kim
2021-01-07 3:11 Stephen Rothwell
2021-01-07 11:28 ` Chao Yu
2021-01-10 20:33 ` Stephen Rothwell
2021-01-10 23:35 ` Jonathan Corbet
2021-01-11 7:54 ` Chao Yu
2021-01-12 5:09 ` Stephen Rothwell
2021-01-12 6:07 ` Chao Yu
2017-02-09 23:51 Stephen Rothwell
2017-02-10 0:01 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127094029.68ce2322@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=gustavo@embeddedor.com \
--cc=jaegeuk@kernel.org \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).