[PATCH] module: remove some duplicated includes

[PATCH] module: remove some duplicated includes

[Yangtao Li]

We include elf.h twice in module.c. It's unnecessary.
hence just remove them.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
 kernel/module.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/module.c b/kernel/module.c
index 49a405891587..438641fc4096 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -28,7 +28,6 @@
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/vmalloc.h>
-#include <linux/elf.h>
 #include <linux/proc_fs.h>
 #include <linux/security.h>
 #include <linux/seq_file.h>
-- 
2.17.0

Re: [PATCH] module: remove some duplicated includes

[Jessica Yu]

+++ Yangtao Li [26/11/18 09:21 -0500]:
>We include elf.h twice in module.c. It's unnecessary.
>hence just remove them.
>
>Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>---
> kernel/module.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/kernel/module.c b/kernel/module.c
>index 49a405891587..438641fc4096 100644
>--- a/kernel/module.c
>+++ b/kernel/module.c
>@@ -28,7 +28,6 @@
> #include <linux/kernel.h>
> #include <linux/slab.h>
> #include <linux/vmalloc.h>
>-#include <linux/elf.h>
> #include <linux/proc_fs.h>
> #include <linux/security.h>
> #include <linux/seq_file.h>

elf.h is not _directly_ included twice in module.c, although it is
included by other header files that module.c pulls in. I'd rather keep
things as-is, since we shouldn't depend on other header files to pull
in the headers we want. I think it's better to keep the explicit
dependence/inclusion of elf.h in module.c.

Thanks,

Jessica