From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Darren Hart <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device()
Date: Tue, 27 Nov 2018 15:46:23 +0200 [thread overview]
Message-ID: <20181127134623.GR10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181127114953.GQ2296@lahna.fi.intel.com>
On Tue, Nov 27, 2018 at 01:49:53PM +0200, Mika Westerberg wrote:
> On Tue, Nov 27, 2018 at 10:16:25AM +0100, Hans de Goede wrote:
> > One problem is that i2c_new_device() currently simply returns NULL on all
> > errors. Andy, you could take a look how much work it is to make that return
> > an ERR_PTR too, or just check its return value and return ERR_PTR(-ENXIO) if
> > it fails for now...
>
> I would use -ENODEV here and -EINVAL in case there is no ACPI companion :)
Sounds more traditional than ENXIO.
I would go the way Mika proposed if there is no objection.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-27 13:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 15:08 [PATCH v2 00/13] i2c-multi-instantiate: Adapt for INT3515 and alike Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 01/13] platform/x86: intel_cht_int33fe: Remove duplicate NULL check Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 02/13] platform/x86: intel_cht_int33fe: Accept errors of i2c_acpi_new_device() Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 03/13] platform/x86: i2c-multi-instantiate: " Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 04/13] platform/x86: i2c-mutli-instantiate: Defer probe when no adapter found Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device() Andy Shevchenko
2018-11-27 9:04 ` Mika Westerberg
2018-11-27 9:16 ` Hans de Goede
2018-11-27 11:49 ` Mika Westerberg
2018-11-27 13:46 ` Andy Shevchenko [this message]
2018-11-27 15:24 ` Hans de Goede
2018-11-27 15:40 ` Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 06/13] i2c: acpi: Use ACPI_FAILURE instead of !ACPI_SUCCESS Andy Shevchenko
2018-11-27 9:05 ` Mika Westerberg
2018-11-26 15:08 ` [PATCH v2 07/13] i2c: acpi: Introduce i2c_acpi_get_i2c_resource() helper Andy Shevchenko
2018-11-27 9:07 ` Mika Westerberg
2018-11-27 14:27 ` Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 08/13] platform/x86: i2c-multi-instantiate: Count I2cSerialBus() resources Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 09/13] platform/x86: i2c-multi-instantiate: Distinguish IRQ resource type Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 10/13] platform/x86: i2c-multi-instantiate: Introduce IOAPIC IRQ support Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 11/13] platform/x86: i2c-multi-instantiate: Allow to have same slaves Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 12/13] ACPI / scan: Create platform device for INT3515 ACPI nodes Andy Shevchenko
2018-11-26 15:08 ` [PATCH v2 13/13] iio: inv_mpu6050: Use i2c_acpi_get_i2c_resource() helper Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127134623.GR10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).