From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Pan Bian <bianpan2016@163.com>, Brian Foster <bfoster@redhat.com>,
Dave Chinner <dchinner@redhat.com>,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] xfs: libxfs: move xfs_perag_put late
Date: Tue, 27 Nov 2018 08:25:16 -0800 [thread overview]
Message-ID: <20181127162516.GG6792@magnolia> (raw)
In-Reply-To: <20181127091602.eaeczahefobpx544@hades.usersys.redhat.com>
On Tue, Nov 27, 2018 at 10:16:02AM +0100, Carlos Maiolino wrote:
> On Tue, Nov 27, 2018 at 08:33:38AM +0800, Pan Bian wrote:
> > The function xfs_alloc_get_freelist calls xfs_perag_put to drop the
> > reference. However, pag->pagf_btreeblks is read and write after the
> > put operation. This patch moves the put operation late.
>
> I'm not a native English speaker too, but I believe it should be "is read and
> written after..."
>
> But, for the code itself, you can add:
>
> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
>
> Cheers
>
> >
> > Signed-off-by: Pan Bian <bianpan2016@163.com>
Looks ok, will amend the changelog on the way in.
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> > ---
> > V2: correct the commit log
> > ---
> > fs/xfs/libxfs/xfs_alloc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> > index e1c0c0d..4be387d 100644
> > --- a/fs/xfs/libxfs/xfs_alloc.c
> > +++ b/fs/xfs/libxfs/xfs_alloc.c
> > @@ -2435,7 +2435,6 @@ xfs_alloc_get_freelist(
> > be32_add_cpu(&agf->agf_flcount, -1);
> > xfs_trans_agflist_delta(tp, -1);
> > pag->pagf_flcount--;
> > - xfs_perag_put(pag);
> >
> > logflags = XFS_AGF_FLFIRST | XFS_AGF_FLCOUNT;
> > if (btreeblk) {
> > @@ -2443,6 +2442,7 @@ xfs_alloc_get_freelist(
> > pag->pagf_btreeblks++;
> > logflags |= XFS_AGF_BTREEBLKS;
> > }
> > + xfs_perag_put(pag);
> >
> > xfs_alloc_log_agf(tp, agbp, logflags);
> > *bnop = bno;
> > --
> > 2.7.4
> >
> >
>
> --
> Carlos
prev parent reply other threads:[~2018-11-27 16:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 0:33 [PATCH V2] xfs: libxfs: move xfs_perag_put late Pan Bian
2018-11-27 9:16 ` Carlos Maiolino
2018-11-27 16:25 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127162516.GG6792@magnolia \
--to=darrick.wong@oracle.com \
--cc=bfoster@redhat.com \
--cc=bianpan2016@163.com \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).