linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: natechancellor@gmail.com
Cc: dmitry.bezrukov@aquantia.com, igor.russkikh@aquantia.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111_suspend
Date: Wed, 28 Nov 2018 21:52:41 -0800 (PST)	[thread overview]
Message-ID: <20181128.215241.702406654469517539.davem@davemloft.net> (raw)
In-Reply-To: <20181129051808.30015-1-natechancellor@gmail.com>

From: Nathan Chancellor <natechancellor@gmail.com>
Date: Wed, 28 Nov 2018 22:18:09 -0700

> Clang warns:
> 
> drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
> initialization of subobject [-Wmissing-braces]
>                 struct aqc111_wol_cfg wol_cfg = { 0 };
>                                                   ^
>                                                   {}
> 1 warning generated.
> 
> Add another set of braces to initialize the char subobjects as well.
> 
> Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

This will in turn make some versions of gcc warn.

Please just memset() this object, thanks.

  reply	other threads:[~2018-11-29  5:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29  5:18 Nathan Chancellor
2018-11-29  5:52 ` David Miller [this message]
2018-11-29  5:54   ` Nathan Chancellor
2018-11-29  6:01 ` [PATCH v2] net: usb: aqc111: Initialize wol_cfg with memset " Nathan Chancellor
2018-12-01  1:26   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128.215241.702406654469517539.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dmitry.bezrukov@aquantia.com \
    --cc=igor.russkikh@aquantia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=natechancellor@gmail.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111_suspend' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).