linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: shuah <shuah@kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Dan Rue <dan.rue@linaro.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the kselftest tree
Date: Wed, 28 Nov 2018 09:27:35 +1100	[thread overview]
Message-ID: <20181128092735.7a2f830f@canb.auug.org.au> (raw)
In-Reply-To: <6235956e-5edd-3b7d-1898-ab55094a7e16@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

Hi Shuah,

On Tue, 27 Nov 2018 14:17:57 -0700 shuah <shuah@kernel.org> wrote:
>
> Thanks for catching this. I will fix it. This is the result of change 
> log content messing up the commit: The diff -Z in the change log 
> resulted in throwing out the Signed-off and Acked-by.

Tricky :-(

> -----------------------------------------------------------------
> diff -Z is used to trim the trailing whitespace when comparing the
> loaded firmware file with the source firmware file. However, per the
> comment in the source code, -Z should not be necessary. In testing, the
> input and output files are identical.
> 
> Additionally, -Z is not a standard option and is not available in
> environments such as busybox. When -Z is not supported, diff fails with
> a usage error, which is suppressed, but then causes read_firmwares() to
> exit with a false failure message.
> --------------------------------------------------------------------
> 
> Oh well! I will fix-up the change-log and amend the commit.

Thanks.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2018-11-27 22:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27 20:36 linux-next: Signed-off-by missing for commit in the kselftest tree Stephen Rothwell
2018-11-27 21:17 ` shuah
2018-11-27 22:27   ` Stephen Rothwell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128092735.7a2f830f@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=dan.rue@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).