From: Thierry Reding <thierry.reding@gmail.com>
To: Wei Ni <wni@nvidia.com>
Cc: daniel.lezcano@linaro.org, linux-tegra@vger.kernel.org,
rui.zhang@intel.com, edubezval@gmail.com, srikars@nvidia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] thermal: tegra: remove unnecessary warnings
Date: Wed, 28 Nov 2018 11:12:27 +0100 [thread overview]
Message-ID: <20181128101227.GB20723@ulmo> (raw)
In-Reply-To: <1543383877-20555-2-git-send-email-wni@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
On Wed, Nov 28, 2018 at 01:44:35PM +0800, Wei Ni wrote:
> Convert warnings to info as not all platforms may
> have all the thresholds and sensors enabled.
>
> Signed-off-by: Wei Ni <wni@nvidia.com>
> ---
> drivers/thermal/tegra/soctherm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
If these are all optional anyway, why even keep the informational
messages? While those may not show up as warnings in the log, they will
still be unconditional noise in the kernel log. Do we really want that,
or should we just trust that the DT is correct and shut up if optional
thresholds and sensors are not present?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-11-28 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 5:44 [PATCH v3 0/3] Fixes for Tegra soctherm Wei Ni
2018-11-28 5:44 ` [PATCH v3 1/3] thermal: tegra: remove unnecessary warnings Wei Ni
2018-11-28 10:12 ` Thierry Reding [this message]
2018-11-29 6:43 ` Wei Ni
2018-11-28 5:44 ` [PATCH v3 2/3] thermal: tegra: fix memory allocation Wei Ni
2018-11-28 5:44 ` [PATCH v3 3/3] thermal: tegra: parse sensor id before sensor register Wei Ni
2018-11-28 5:55 ` Wei Ni
2018-11-28 10:25 ` Thierry Reding
2018-11-29 5:55 ` Wei Ni
2018-11-29 17:13 ` Thierry Reding
2018-11-30 3:10 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128101227.GB20723@ulmo \
--to=thierry.reding@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=srikars@nvidia.com \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).