From: kbuild test robot <lkp@intel.com>
To: Andrei.Stefanescu@microchip.com
Cc: kbuild-all@01.org, lgirdwood@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com, gregkh@linuxfoundation.org,
Nicolas.Ferre@microchip.com, Cristian.Birsan@microchip.com,
Claudiu.Beznea@microchip.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Andrei.Stefanescu@microchip.com
Subject: Re: [PATCH v2 3/3] regulator: mcp16502: add regulator driver for MCP16502
Date: Wed, 28 Nov 2018 11:28:56 +0800 [thread overview]
Message-ID: <201811281107.R2ycG2WQ%fengguang.wu@intel.com> (raw)
In-Reply-To: <1543335937-12689-4-git-send-email-andrei.stefanescu@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 2936 bytes --]
Hi Andrei.Stefanescu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on regulator/for-next]
[also build test ERROR on v4.20-rc4 next-20181127]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Andrei-Stefanescu-microchip-com/add-support-for-MCP16502-PMIC/20181128-041809
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: sh-allyesconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=sh
All error/warnings (new ones prefixed by >>):
drivers//regulator/mcp16502.c: In function 'mcp16502_suspend_get_target_reg':
>> drivers//regulator/mcp16502.c:273:10: error: 'pm_suspend_target_state' undeclared (first use in this function); did you mean 'pm_suspended_storage'?
switch (pm_suspend_target_state) {
^~~~~~~~~~~~~~~~~~~~~~~
pm_suspended_storage
drivers//regulator/mcp16502.c:273:10: note: each undeclared identifier is reported only once for each function it appears in
drivers//regulator/mcp16502.c: In function 'mcp16502_set_suspend_mode':
drivers//regulator/mcp16502.c:310:10: error: 'pm_suspend_target_state' undeclared (first use in this function); did you mean 'pm_suspended_storage'?
switch (pm_suspend_target_state) {
^~~~~~~~~~~~~~~~~~~~~~~
pm_suspended_storage
drivers//regulator/mcp16502.c: In function 'mcp16502_suspend_get_target_reg':
>> drivers//regulator/mcp16502.c:284:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
drivers//regulator/mcp16502.c: In function 'mcp16502_set_suspend_mode':
drivers//regulator/mcp16502.c:321:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
vim +273 drivers//regulator/mcp16502.c
266
267 /*
268 * mcp16502_suspend_get_target_reg() - get the reg of the target suspend PMIC
269 * mode
270 */
271 static int mcp16502_suspend_get_target_reg(struct regulator_dev *rdev)
272 {
> 273 switch (pm_suspend_target_state) {
274 case PM_SUSPEND_STANDBY:
275 return mcp16502_get_reg(rdev, MCP16502_OPMODE_LPM);
276 case PM_SUSPEND_ON:
277 case PM_SUSPEND_MEM:
278 return mcp16502_get_reg(rdev, MCP16502_OPMODE_HIB);
279 default:
280 dev_err(&rdev->dev, "invalid suspend target: %d\n",
281 pm_suspend_target_state);
282 return -EINVAL;
283 }
> 284 }
285
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50575 bytes --]
next prev parent reply other threads:[~2018-11-28 3:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 16:25 [PATCH v2 0/3] add support for MCP16502 PMIC Andrei.Stefanescu
2018-11-27 16:25 ` [PATCH v2 1/3] regulator: dt-bindings: add MCP16502 regulator bindings Andrei.Stefanescu
2018-11-27 16:25 ` [PATCH v2 2/3] MAINTAINERS: add maintainer for MCP16502 PMIC driver Andrei.Stefanescu
2018-11-27 16:25 ` [PATCH v2 3/3] regulator: mcp16502: add regulator driver for MCP16502 Andrei.Stefanescu
2018-11-28 3:28 ` kbuild test robot [this message]
2018-11-28 4:02 ` kbuild test robot
2018-11-28 4:02 ` [PATCH] regulator: mcp16502: fix platform_no_drv_owner.cocci warnings kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201811281107.R2ycG2WQ%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=Andrei.Stefanescu@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Cristian.Birsan@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).