[PATCH net-next] net: qualcomm: rmnet: remove set but not used variables 'ip_family, fc_seq, qos_id'

[PATCH net-next] net: qualcomm: rmnet: remove set but not used variables 'ip_family, fc_seq, qos_id'

[YueHaibing]

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:26:6:
 warning: variable 'ip_family' set but not used [-Wunused-but-set-variable]
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:27:6:
 warning: variable 'fc_seq' set but not used [-Wunused-but-set-variable]
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:28:6:
 warning: variable 'qos_id' set but not used [-Wunused-but-set-variable]

It never used since introduction in commit
ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
index 3ee8ae9..8990307 100644
--- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
+++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c
@@ -23,9 +23,6 @@ static u8 rmnet_map_do_flow_control(struct sk_buff *skb,
 	struct rmnet_map_control_command *cmd;
 	struct rmnet_endpoint *ep;
 	struct net_device *vnd;
-	u16 ip_family;
-	u16 fc_seq;
-	u32 qos_id;
 	u8 mux_id;
 	int r;
 
@@ -45,10 +42,6 @@ static u8 rmnet_map_do_flow_control(struct sk_buff *skb,
 
 	vnd = ep->egress_dev;
 
-	ip_family = cmd->flow_control.ip_family;
-	fc_seq = ntohs(cmd->flow_control.flow_control_seq_num);
-	qos_id = ntohl(cmd->flow_control.qos_id);
-
 	/* Ignore the ip family and pass the sequence number for both v4 and v6
 	 * sequence. User space does not support creating dedicated flows for
 	 * the 2 protocols
-- 
2.7.0

Re: [PATCH net-next] net: qualcomm: rmnet: remove set but not used variables 'ip_family, fc_seq, qos_id'

[David Miller]

From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 28 Nov 2018 20:31:42 +0800

> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:26:6:
>  warning: variable 'ip_family' set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:27:6:
>  warning: variable 'fc_seq' set but not used [-Wunused-but-set-variable]
> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:28:6:
>  warning: variable 'qos_id' set but not used [-Wunused-but-set-variable]
> 
> It never used since introduction in commit
> ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.