From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4F98C43441 for ; Wed, 28 Nov 2018 17:40:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C6742081B for ; Wed, 28 Nov 2018 17:40:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="VdaIQoKU"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cP05VVnF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C6742081B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729228AbeK2Em0 (ORCPT ); Wed, 28 Nov 2018 23:42:26 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:48850 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728163AbeK2Em0 (ORCPT ); Wed, 28 Nov 2018 23:42:26 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0E93060392; Wed, 28 Nov 2018 17:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1543426801; bh=DBrPedqt3keC5Va9cYddAXOg6ruPF4Eifjwg8KYVtk4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VdaIQoKUoKpJTkhOTsAW6n43ivwJUck3pIUESsFSpqgO/Ov5T2MeDn28JUHTL/DjH 6333VoLNqcolC2lgPPTttNm5uqa+Jl0i9V508bKDuALSqarj7fwLaNBd4awqYpsrON mrI0z4d8KBnGU8aLsswVgfWv3+kM4RKPWG37jDHc= Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: ilina@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 38CC9606DC; Wed, 28 Nov 2018 17:40:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1543426800; bh=DBrPedqt3keC5Va9cYddAXOg6ruPF4Eifjwg8KYVtk4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cP05VVnFlk8vRX1zBPwHXMiVhnEmIhUezPYBbgbaB0zIoOp3nT+hkJy0ftiHgB7ei BfCTUSXiSpLL9a7+JemKhgRH/eCMSL08Z+Fna8rxU8NtLUL+K9BfAFXKU7WJbs7Swn JlCQwjL/Qb9mLQDwqKFHcZ5D9HBQZLcFEYVVUaPw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 38CC9606DC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilina@codeaurora.org Date: Wed, 28 Nov 2018 10:39:59 -0700 From: Lina Iyer To: Stephen Boyd Cc: evgreen@chromium.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, rplsssn@codeaurora.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, thierry.reding@gmail.com Subject: Re: [RFC v3 2/3] dt-bindings: sdm845-pinctrl: add wakeup interrupt parent for GPIO Message-ID: <20181128173959.GC18262@codeaurora.org> References: <20181121000648.29262-1-ilina@codeaurora.org> <20181121000648.29262-3-ilina@codeaurora.org> <154283618199.88331.10217252750356423959@swboyd.mtv.corp.google.com> <20181126161455.GA28236@codeaurora.org> <154330994255.88331.11409511159882116164@swboyd.mtv.corp.google.com> <20181127182123.GC28236@codeaurora.org> <154335513853.88331.9713562640538396853@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <154335513853.88331.9713562640538396853@swboyd.mtv.corp.google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 27 2018 at 14:45 -0700, Stephen Boyd wrote: >Quoting Lina Iyer (2018-11-27 10:21:23) >> On Tue, Nov 27 2018 at 02:12 -0700, Stephen Boyd wrote: >> > >> >Two reasons. First, simplicity. The TLMM driver just needs to pass the >> >gpio number up to the PDC gpio domain and then that domain can figure >> >out what hwirq it maps to within the PDC hw irq space. I don't see any >> >reason why we have to know the hwirq of PDC within the TLMM driver >> >besides "let's not be different". >> > >> >And second, it makes it easier for us to implement the MPM case in the >> >TLMM driver by letting the TLMM code just ask "should I mask the irq >> >here or not?" by passing that with a wrapper struct around the fwspec >> >and a dedicated domain in the PDC/MPM driver. Keeping less things in the >> >TLMM driver and not driving the decision from DT but from tables in the >> >PDC driver also keeps things simple and reduces DT parsing code/time. >> > >> Couldn't this be simply achieved by matching the compatible flags for >> PDC/MPM bindings for the wakeup-parent in the TLMM driver? >> > >It could be, but then we would be making TLMM highly aware of the wakeup >parent It is is not aware of anything about the wakeup parent, just the compatible that indicates whether it needs to be mask locally or not. >and have to do compatible string matching in two places, instead >of making TLMM more abstractly aware that it needs to keep things masked >while irq parent deals with the interrupts. > Your approach seems too complex just to circumvent a simple match node. I think we are stretching too much to support something that is not a priority. -- Lina