From: David Miller <davem@davemloft.net>
To: ms@dev.tdt.de
Cc: andrew.hendry@gmail.com, stephen@networkplumber.org,
joe@perches.com, anto.cardace@gmail.com,
linux-x25@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] net/x25: fix null_x25_address handling
Date: Thu, 29 Nov 2018 14:26:09 -0800 (PST) [thread overview]
Message-ID: <20181129.142609.820562472340154653.davem@davemloft.net> (raw)
In-Reply-To: <20181127085029.9589-2-ms@dev.tdt.de>
From: Martin Schiller <ms@dev.tdt.de>
Date: Tue, 27 Nov 2018 09:50:28 +0100
> o x25_find_listener(): the compare for the null_x25_address was wrong.
> We have to check the x25_addr of the listener socket instead of the
> x25_addr of the incomming call.
>
> o x25_bind(): it was not possible to bind a socket to null_x25_address
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Applied.
next prev parent reply other threads:[~2018-11-29 22:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 8:50 [PATCH 1/3] net/x25: fix called/calling length calculation in x25_parse_address_block Martin Schiller
2018-11-27 8:50 ` [PATCH 2/3] net/x25: fix null_x25_address handling Martin Schiller
2018-11-29 22:26 ` David Miller [this message]
2018-11-27 8:50 ` [PATCH 3/3] net/x25: handle call collisions Martin Schiller
2018-11-29 22:26 ` David Miller
2018-11-29 22:26 ` [PATCH 1/3] net/x25: fix called/calling length calculation in x25_parse_address_block David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129.142609.820562472340154653.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.hendry@gmail.com \
--cc=anto.cardace@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).