[PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111_suspend

[PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111_suspend

[Nathan Chancellor]

Clang warns:

drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
initialization of subobject [-Wmissing-braces]
                struct aqc111_wol_cfg wol_cfg = { 0 };
                                                  ^
                                                  {}
1 warning generated.

Add another set of braces to initialize the char subobjects as well.

Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
 drivers/net/usb/aqc111.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c
index f69d566bd523..1c2db1191073 100644
--- a/drivers/net/usb/aqc111.c
+++ b/drivers/net/usb/aqc111.c
@@ -1323,7 +1323,7 @@ static int aqc111_suspend(struct usb_interface *intf, pm_message_t message)
 			      1, 1, &reg8);
 
 	if (aqc111_data->wol_flags) {
-		struct aqc111_wol_cfg wol_cfg = { 0 };
+		struct aqc111_wol_cfg wol_cfg = { { 0 } };
 
 		aqc111_data->phy_cfg |= AQ_WOL;
 		ether_addr_copy(wol_cfg.hw_addr, dev->net->dev_addr);
-- 
2.20.0.rc1

Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111_suspend

[David Miller]

From: Nathan Chancellor <natechancellor@gmail.com>
Date: Wed, 28 Nov 2018 22:18:09 -0700

> Clang warns:
> 
> drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
> initialization of subobject [-Wmissing-braces]
>                 struct aqc111_wol_cfg wol_cfg = { 0 };
>                                                   ^
>                                                   {}
> 1 warning generated.
> 
> Add another set of braces to initialize the char subobjects as well.
> 
> Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

This will in turn make some versions of gcc warn.

Please just memset() this object, thanks.

Re: [PATCH] net: usb: aqc111: Properly initialize wol_cfg in aqc111_suspend

[Nathan Chancellor]

On Wed, Nov 28, 2018 at 09:52:41PM -0800, David Miller wrote:
> From: Nathan Chancellor <natechancellor@gmail.com>
> Date: Wed, 28 Nov 2018 22:18:09 -0700
> 
> > Clang warns:
> > 
> > drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
> > initialization of subobject [-Wmissing-braces]
> >                 struct aqc111_wol_cfg wol_cfg = { 0 };
> >                                                   ^
> >                                                   {}
> > 1 warning generated.
> > 
> > Add another set of braces to initialize the char subobjects as well.
> > 
> > Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> 
> This will in turn make some versions of gcc warn.
> 
> Please just memset() this object, thanks.

I thought this was the form that all compilers seemed to agree on but
sure, I will send a v2.

Thanks for the quick response,
Nathan

[PATCH v2] net: usb: aqc111: Initialize wol_cfg with memset in aqc111_suspend

[Nathan Chancellor]

Clang warns:

drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
initialization of subobject [-Wmissing-braces]
                struct aqc111_wol_cfg wol_cfg = { 0 };
                                                  ^
                                                  {}
1 warning generated.

Use memset to initialize the object to take compiler instrumentation out
of the equation.

Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---

v1 -> v2:

* Use memset instead of braces.

 drivers/net/usb/aqc111.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c
index f69d566bd523..57f1c94fca0b 100644
--- a/drivers/net/usb/aqc111.c
+++ b/drivers/net/usb/aqc111.c
@@ -1323,7 +1323,9 @@ static int aqc111_suspend(struct usb_interface *intf, pm_message_t message)
 			      1, 1, &reg8);
 
 	if (aqc111_data->wol_flags) {
-		struct aqc111_wol_cfg wol_cfg = { 0 };
+		struct aqc111_wol_cfg wol_cfg;
+
+		memset(&wol_cfg, 0, sizeof(struct aqc111_wol_cfg));
 
 		aqc111_data->phy_cfg |= AQ_WOL;
 		ether_addr_copy(wol_cfg.hw_addr, dev->net->dev_addr);
-- 
2.20.0.rc1

Re: [PATCH v2] net: usb: aqc111: Initialize wol_cfg with memset in aqc111_suspend

[David Miller]

From: Nathan Chancellor <natechancellor@gmail.com>
Date: Wed, 28 Nov 2018 23:01:05 -0700

> Clang warns:
> 
> drivers/net/usb/aqc111.c:1326:37: warning: suggest braces around
> initialization of subobject [-Wmissing-braces]
>                 struct aqc111_wol_cfg wol_cfg = { 0 };
>                                                   ^
>                                                   {}
> 1 warning generated.
> 
> Use memset to initialize the object to take compiler instrumentation out
> of the equation.
> 
> Fixes: e58ba4544c77 ("net: usb: aqc111: Add support for wake on LAN by MAGIC packet")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Applied.