From: Artem Savkov <asavkov@redhat.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
"Eric W . Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/tools/relocs: fix big section header tables
Date: Thu, 29 Nov 2018 16:22:00 +0100 [thread overview]
Message-ID: <20181129152200.GA1776@shodan.usersys.redhat.com> (raw)
In-Reply-To: <20181129142312.kz2l5gm33yeaglnn@treble>
On Thu, Nov 29, 2018 at 08:23:12AM -0600, Josh Poimboeuf wrote:
> On Thu, Nov 29, 2018 at 02:51:33PM +0100, Artem Savkov wrote:
> > In case when the number of entries in the section header table is larger
> > then or equal to SHN_LORESERVE the size of the table is held in the sh_size
> > member of the initial entry in section header table instead of e_shnum.
> > Same with the string table index which is located in sh_link instead of
> > e_shstrndx.
> >
> > This case is easily reproducible with KCFLAGS="-ffunction-sections",
> > bzImage build fails with "String table index out of bounds" error.
> >
> > Signed-off-by: Artem Savkov <asavkov@redhat.com>
> > ---
> > arch/x86/tools/relocs.c | 58 +++++++++++++++++++++++++++++------------
> > 1 file changed, 41 insertions(+), 17 deletions(-)
> >
> > diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c
> > index b629f6992d9f..5275ea0a0d13 100644
> > --- a/arch/x86/tools/relocs.c
> > +++ b/arch/x86/tools/relocs.c
> > @@ -11,7 +11,9 @@
> > #define Elf_Shdr ElfW(Shdr)
> > #define Elf_Sym ElfW(Sym)
> >
> > -static Elf_Ehdr ehdr;
> > +static Elf_Ehdr ehdr;
>
> I think there's a tab missing here, it doesn't line up with the other
> variables.
This seems to be a vim bug. It aligns perfectly in
cat/less/lore.kernel.org which all seem to use tabstop=8 by default, but
it does not align in vim, but it does align with tabstop=7 in vim.
--
Artem
next prev parent reply other threads:[~2018-11-29 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 13:51 [PATCH] x86/tools/relocs: fix big section header tables Artem Savkov
2018-11-29 14:23 ` Josh Poimboeuf
2018-11-29 15:22 ` Artem Savkov [this message]
2018-11-29 15:32 ` Josh Poimboeuf
2018-11-29 15:56 ` [PATCH v2] " Artem Savkov
2018-11-29 15:57 ` Josh Poimboeuf
2019-01-11 19:09 ` Joe Lawrence
2019-04-19 19:01 ` [tip:x86/build] x86/tools/relocs: Fix " tip-bot for Artem Savkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129152200.GA1776@shodan.usersys.redhat.com \
--to=asavkov@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).