From: Mark Brown <broonie@kernel.org>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
ckeepax@opensource.cirrus.com
Subject: Re: [PATCH 00/10] Regulator ena_gpiod fixups
Date: Thu, 29 Nov 2018 19:01:32 +0000 [thread overview]
Message-ID: <20181129190132.GM2089@sirena.org.uk> (raw)
In-Reply-To: <CAMpxmJUsAccSKELNxn6DEWO6_3aCbzM=hZyaXUCr30S0-Eh0mA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 852 bytes --]
On Thu, Nov 29, 2018 at 07:38:20PM +0100, Bartosz Golaszewski wrote:
> I'm wondering if instead of using the non-devm variants of
> gpiod_get_*() routines, we shouldn't provide helpers in the regulator
> framework that would be named accordingly, for example:
> regulator_gpiod_get_optional() etc. even if all they do is call the
> relevant gpiolib function. Those helpers could then be documented as
> passing the control over GPIO lines over to the regulator subsystem.
> The reason for that is that most driver developers will automatically
> use devm functions whenever available and having a single non-devm
> function without any comment used in a driver normally using devres
> looks like a bug. Expect people sending "fixes" in a couple months.
I predict that people would then immediately start demanding devm_
variants of that function...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-29 19:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 10:43 [PATCH 00/10] Regulator ena_gpiod fixups Linus Walleij
2018-11-28 10:43 ` [PATCH 01/10] regulator: fixed: Let core handle GPIO descriptor Linus Walleij
2018-11-28 10:43 ` [PATCH 02/10] regulator: lm363x: " Linus Walleij
2018-11-28 10:43 ` [PATCH 03/10] regulator: lp8788-ldo: " Linus Walleij
2018-11-28 10:43 ` [PATCH 04/10] regulator: max8952: " Linus Walleij
2018-11-28 10:43 ` [PATCH 05/10] regulator: max8973: " Linus Walleij
2018-11-28 10:43 ` [PATCH 06/10] gpio: Export gpiod_get_from_of_node() Linus Walleij
2018-11-28 10:43 ` [PATCH 07/10] regulator: da9211: Let core handle GPIO descriptors Linus Walleij
2018-11-28 15:11 ` Charles Keepax
2018-11-28 10:43 ` [PATCH 08/10] regulator: max77686: Let core handle GPIO descriptor Linus Walleij
2018-11-28 15:24 ` Charles Keepax
2018-11-30 9:07 ` Linus Walleij
2018-11-28 10:43 ` [PATCH 09/10] regulator: s5m8767: Let core handle GPIO descriptors Linus Walleij
2018-11-28 15:17 ` Charles Keepax
2018-11-28 10:43 ` [PATCH 10/10] regulator: tps65090: " Linus Walleij
2018-11-28 15:18 ` Charles Keepax
2018-11-28 15:22 ` [PATCH 00/10] Regulator ena_gpiod fixups Charles Keepax
2018-11-29 15:52 ` Linus Walleij
2018-11-29 16:29 ` Mark Brown
2018-11-29 18:38 ` Bartosz Golaszewski
2018-11-29 19:01 ` Mark Brown [this message]
2018-11-30 8:35 ` Bartosz Golaszewski
2018-11-30 10:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129190132.GM2089@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).