From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D65ECC65BAE for ; Thu, 29 Nov 2018 23:51:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A310A21019 for ; Thu, 29 Nov 2018 23:51:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A310A21019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbeK3K65 (ORCPT ); Fri, 30 Nov 2018 05:58:57 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:36150 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726425AbeK3K65 (ORCPT ); Fri, 30 Nov 2018 05:58:57 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.91 #2 (Red Hat Linux)) id 1gSW5i-0005HN-Tf; Thu, 29 Nov 2018 23:51:31 +0000 Date: Thu, 29 Nov 2018 23:51:30 +0000 From: Al Viro To: Paul Moore Cc: omosnace@redhat.com, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, selinux@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: linux-next: manual merge of the selinux tree with the vfs tree Message-ID: <20181129235130.GI2217@ZenIV.linux.org.uk> References: <20181127115246.00967523@canb.auug.org.au> <20181127225013.133adc7d@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 29, 2018 at 05:23:24PM -0500, Paul Moore wrote: > > OK, I will verify that the SELinux submount fix rebased on top of > > vfs/work.mount in the way I suggested above passes the same testing > > (seliinux-testsuite + NFS crossmnt reproducer). I am now building two > > kernels (vfs/work.mount with and without the fix) to test. Let me know > > if there is anything more to do. > > Thanks. > > The big thing is just making sure that we don't regress on the fix in > selinux/next if/when David's mount rework hits Linus' tree. FWIW, the whole thing is getting massaged/reordered/etc. and I would like some input from you guys at some point - assuming that I recover the ability to talk about LSM without obscenities... Question: what *should* happen if we try to cross into a submount and find that the thing on the other side is already mounted elsewhere, with incompatible LSM options? Ditto for referrals, with an extra twist - what if we are given 3 alternatives, the first two already mounted elsewhere with incompatible options, the third one not mounted anywhere yet? Incidentally, should smack have ->sb_clone_mnt_opts()?