From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Vincent Guittot <vincent.guittot@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Niklas Cassel <niklas.cassel@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 3/5] PM / Domains: Save OPP table pointer in genpd
Date: Fri, 30 Nov 2018 14:35:21 +0530 [thread overview]
Message-ID: <20181130090521.etwm56dcvfgk5qkl@vireshk-i7> (raw)
In-Reply-To: <CAPDyKFrUBwagtfwCezqw2ujPBVVtQNqz4rKgAG0Yyy18FZv+wA@mail.gmail.com>
On 30-11-18, 09:53, Ulf Hansson wrote:
> > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> > index 8e554e6a82a2..0d928359b880 100644
> > --- a/drivers/base/power/domain.c
> > +++ b/drivers/base/power/domain.c
> > @@ -1907,12 +1907,21 @@ int of_genpd_add_provider_simple(struct device_node *np,
> > ret);
> > goto unlock;
> > }
> > +
> > + /*
> > + * Save table for faster processing while setting performance
> > + * state.
> > + */
> > + genpd->opp_table = dev_pm_opp_get_opp_table(&genpd->dev);
> > + WARN_ON(!genpd->opp_table);
>
> The WARN_ON seems lazy. Why not implement a proper error path?
We just added the table before this call and so we should get the table no
matter what. Initially I wanted to add a BUG_ON() but then I relaxed it a bit :)
There is no point of error path here as that will never run.
--
viresh
next prev parent reply other threads:[~2018-11-30 9:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 8:09 [PATCH V2 0/5] PM / Domains: Allow performance state propagation Viresh Kumar
2018-11-26 8:10 ` [PATCH V2 1/5] OPP: Improve _find_table_of_opp_np() Viresh Kumar
2018-11-26 8:10 ` [PATCH V2 2/5] OPP: Add dev_pm_opp_xlate_performance_state() helper Viresh Kumar
2018-11-30 8:45 ` Ulf Hansson
2018-12-03 6:42 ` Viresh Kumar
2018-11-26 8:10 ` [PATCH V2 3/5] PM / Domains: Save OPP table pointer in genpd Viresh Kumar
2018-11-30 8:53 ` Ulf Hansson
2018-11-30 9:05 ` Viresh Kumar [this message]
2018-12-03 6:57 ` Viresh Kumar
2018-11-26 8:10 ` [PATCH V2 4/5] PM / Domains: Factorize dev_pm_genpd_set_performance_state() Viresh Kumar
2018-11-30 8:54 ` Ulf Hansson
2018-11-26 8:10 ` [PATCH V2 5/5] PM / Domains: Propagate performance state updates Viresh Kumar
2018-11-30 9:44 ` Ulf Hansson
2018-11-30 9:59 ` Viresh Kumar
2018-11-30 10:18 ` Ulf Hansson
2018-11-30 11:06 ` Viresh Kumar
2018-12-03 13:38 ` Ulf Hansson
2018-12-05 6:42 ` Stephen Boyd
2018-12-05 17:29 ` Ulf Hansson
2018-12-03 8:50 ` Viresh Kumar
2018-11-27 4:50 ` [PATCH V2 0/5] PM / Domains: Allow performance state propagation Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130090521.etwm56dcvfgk5qkl@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).