From: Christoph Hellwig <hch@lst.de>
To: Maximilian Heyne <mheyne@amazon.de>
Cc: Christoph Hellwig <hch@lst.de>, Torsten Mehlan <tomeh@amazon.de>,
Uwe Dannowski <uwed@amazon.de>, Amit Shah <aams@amazon.de>,
David Woodhouse <dwmw@amazon.co.uk>,
stable@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
axboe@kernel.dk
Subject: Re: [PATCH v2] fs: fix lost error code in dio_complete
Date: Fri, 30 Nov 2018 11:46:20 +0100 [thread overview]
Message-ID: <20181130104620.GA26765@lst.de> (raw)
In-Reply-To: <83319cde-9855-d544-8079-15e028f4458f@amazon.de>
Al, Jens,
can someone pick this up, please?
On Fri, Nov 30, 2018 at 10:02:22AM +0100, Maximilian Heyne wrote:
> On 11/8/18 7:58 PM, Maximilian Heyne wrote:
>> commit e259221763a40403d5bb232209998e8c45804ab8 ("fs: simplify the
>> generic_write_sync prototype") reworked callers of generic_write_sync(),
>> and ended up dropping the error return for the directio path. Prior to
>> that commit, in dio_complete(), an error would be bubbled up the stack,
>> but after that commit, errors passed on to dio_complete were eaten up.
>>
>> This was reported on the list earlier, and a fix was proposed in
>> https://lore.kernel.org/lkml/20160921141539.GA17898@infradead.org/, but
>> never followed up with. We recently hit this bug in our testing where
>> fencing io errors, which were previously erroring out with EIO, were
>> being returned as success operations after this commit.
> I just wanted to follow up on this. Has anyone picked up this patch?
>
>
>
> Amazon Development Center Germany GmbH
> Krausenstr. 38
> 10117 Berlin
> Geschaeftsfuehrer: Christian Schlaeger, Ralf Herbrich
> Ust-ID: DE 289 237 879
> Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
>
---end quoted text---
next prev parent reply other threads:[~2018-11-30 10:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 18:58 [PATCH v2] fs: fix lost error code in dio_complete Maximilian Heyne
2018-11-30 9:02 ` Maximilian Heyne
2018-11-30 10:46 ` Christoph Hellwig [this message]
2018-11-30 15:15 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130104620.GA26765@lst.de \
--to=hch@lst.de \
--cc=aams@amazon.de \
--cc=axboe@kernel.dk \
--cc=dwmw@amazon.co.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mheyne@amazon.de \
--cc=stable@vger.kernel.org \
--cc=tomeh@amazon.de \
--cc=uwed@amazon.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).