From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2412C04EB8 for ; Fri, 30 Nov 2018 18:33:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DE4120673 for ; Fri, 30 Nov 2018 18:33:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Tjd8VjpE"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="Tjd8VjpE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DE4120673 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726629AbeLAFn3 (ORCPT ); Sat, 1 Dec 2018 00:43:29 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:47916 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbeLAFn3 (ORCPT ); Sat, 1 Dec 2018 00:43:29 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C746260722; Fri, 30 Nov 2018 18:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1543602798; bh=w1YOISgnFGQ9t25xcC2pzlLpTrEx04CYGtevYBKAJrs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tjd8VjpEqZyWMhSUiRR8IlA2dGtjPggR2s+DorIwiEbMdpBkKjZwPASI4j+W2JIHS 9T9n3AIHKd9twcH1NDoos2Ts+QcwFVcMdLN2VzvP7bUrmNPSpFn+VYbvmqz9KchvRr vaLQR3XYlPTuunF+OctG6lLJTnzqAOgkmelxX/1s= Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: ilina@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 547C660251; Fri, 30 Nov 2018 18:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1543602798; bh=w1YOISgnFGQ9t25xcC2pzlLpTrEx04CYGtevYBKAJrs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tjd8VjpEqZyWMhSUiRR8IlA2dGtjPggR2s+DorIwiEbMdpBkKjZwPASI4j+W2JIHS 9T9n3AIHKd9twcH1NDoos2Ts+QcwFVcMdLN2VzvP7bUrmNPSpFn+VYbvmqz9KchvRr vaLQR3XYlPTuunF+OctG6lLJTnzqAOgkmelxX/1s= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 547C660251 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=ilina@codeaurora.org Date: Fri, 30 Nov 2018 11:33:17 -0700 From: Lina Iyer To: Bjorn Andersson Cc: Stephen Boyd , evgreen@chromium.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, rplsssn@codeaurora.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, thierry.reding@gmail.com Subject: Re: [RFC v3 2/3] dt-bindings: sdm845-pinctrl: add wakeup interrupt parent for GPIO Message-ID: <20181130183317.GL18262@codeaurora.org> References: <20181121000648.29262-1-ilina@codeaurora.org> <20181121000648.29262-3-ilina@codeaurora.org> <154283618199.88331.10217252750356423959@swboyd.mtv.corp.google.com> <20181126161455.GA28236@codeaurora.org> <154330994255.88331.11409511159882116164@swboyd.mtv.corp.google.com> <20181127182123.GC28236@codeaurora.org> <154335513853.88331.9713562640538396853@swboyd.mtv.corp.google.com> <20181128173959.GC18262@codeaurora.org> <20181129002457.GJ24969@minitux> <20181129214539.GG18262@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20181129214539.GG18262@codeaurora.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 29 2018 at 14:45 -0700, Lina Iyer wrote: >On Wed, Nov 28 2018 at 17:25 -0700, Bjorn Andersson wrote: >>On Wed 28 Nov 09:39 PST 2018, Lina Iyer wrote: >> >>>On Tue, Nov 27 2018 at 14:45 -0700, Stephen Boyd wrote: >>>> Quoting Lina Iyer (2018-11-27 10:21:23) >>>> > On Tue, Nov 27 2018 at 02:12 -0700, Stephen Boyd wrote: [...] >BTW, I am discussing with the internal folks here on if we need to mask >TLMM when the wakeup-parent is MPM. If we don't have to, we should be >able to follow the same model as we done in this patch and don't even >have to check the compatible or use the approach suggested by Stephen. > The TLMM and the MPM are not active at the same time. However, there is a small chance they might be (a few clock cycles) when the system is going down, but even then, since we replay the interrupt from the MPM driver before the interrupts are serviced by Linux, we would not see multiple GPIO interrupts. The way we have MPM working downstream, for a wakeup GPIO IRQ - a. Application cores gets a wakeup interrupt either from RPM or GIC (if TLMM was not powered down) while still in the interrupt locked context. b. In the hardware, apps core handshakes with the RPM and then starts resuming from the platform's system idle driver. c. The first CPU to wake up calls MPM driver from the idle driver, which reads the shared memory to find the MPM pins that are set. Converts the MPM pins to their corresponding linux interrupt and replays the interrupt. d. Idle driver exits and wakeup GPIO interrupt is handled. The MPM pins are not updated after the RPM lets the application core to run. Since TLMM is functional after the RPM handshake, it takes over. Note, the downstream design is predicated on the OS-Initiated support for all MPM based SoCs which serializes the last CPU going down and the first CPU coming out of idle. Thanks, Lina