From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30BD2C65BAE for ; Fri, 30 Nov 2018 21:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE2DF20660 for ; Fri, 30 Nov 2018 21:07:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE2DF20660 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726766AbeLAISQ (ORCPT ); Sat, 1 Dec 2018 03:18:16 -0500 Received: from mga02.intel.com ([134.134.136.20]:20447 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbeLAISQ (ORCPT ); Sat, 1 Dec 2018 03:18:16 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Nov 2018 13:07:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,299,1539673200"; d="scan'208";a="121033317" Received: from jsakkine-mobl1.jf.intel.com (HELO localhost) ([10.241.225.27]) by fmsmga001.fm.intel.com with ESMTP; 30 Nov 2018 13:07:39 -0800 Date: Fri, 30 Nov 2018 13:07:39 -0800 From: Jarkko Sakkinen To: Kees Cook Cc: LKML , Amir Goldstein , Andrew Morton , Andy Shevchenko , Daniel Axtens , "David S. Miller" , Dominik Brodowski , Maling list - DRI developers , Eric Dumazet , federico.vaga@vaga.pv.it, Geert Uytterhoeven , Helge Deller , Jonathan Corbet , Joshua Kinard , "open list:DOCUMENTATION" , "linux-fsdevel@vger.kernel.org" , linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Linux Media Mailing List , Linux MIPS Mailing List , Linux mtd , linux-parisc , Linux PM list , linux-scsi@vger.kernel.org, matthias.bgg@gmail.com, Network Development , nouveau , Paolo Abeni , Paul Burton , Petr Mladek , Rob Herring , sean.wang@mediatek.com, Sergey Senozhatsky , shannon.nelson@oracle.com, Stefano Brivio , Steven Rostedt , "Tobin C. Harding" , makita.toshiaki@lab.ntt.co.jp, Willem de Bruijn , Yonghong Song , yanjun.zhu@oracle.com Subject: Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3 Message-ID: <20181130210739.GD22338@linux.intel.com> References: <20181130192737.15053-1-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 30, 2018 at 11:40:17AM -0800, Kees Cook wrote: > On Fri, Nov 30, 2018 at 11:27 AM Jarkko Sakkinen > wrote: > > > > In order to comply with the CoC, replace **** with a hug. > > Heh. I support the replacement of the stronger language, but I find > "hug", "hugged", and "hugging" to be very weird replacements. Can we > bikeshed this to "heck", "hecked", and "hecking" (or "heckin" to > follow true Doggo meme style). > > "This API is hugged" doesn't make any sense to me. "This API is > hecked" is better, or at least funnier (to me). "Hug this interface" > similarly makes no sense, but "Heck this interface" seems better. > "Don't touch my hecking code", "What the heck were they thinking?" > etc... "hug" is odd. > > Better yet, since it's only 17 files, how about doing context-specific > changes? "This API is terrible", "Hateful interface", "Don't touch my > freakin' code", "What in the world were they thinking?" etc? I'm happy to refine this (thus the RFC tag)! And depending on the culture, hugging could fall in the harrasment category. Actually, when I think about it, in Finland this kind of poking of ones personal bubble would be such :-) I'll refine the patch set with more context sensitive replacements, perhaps removing the comment altogether in some places. Thank you for the feedback! /Jarkko