linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Chris Chiu <chiu@endlessm.com>
Cc: kbuild-all@01.org, jikos@kernel.org,
	benjamin.tissoires@redhat.com, rydberg@bitmath.org,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux@endlessm.com, Chris Chiu <chiu@endlessm.com>
Subject: Re: [PATCH] HID: input: support Microsoft wireless radio control hotkey
Date: Fri, 30 Nov 2018 23:03:56 +0800	[thread overview]
Message-ID: <201811302350.rf2toQVX%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181130064617.67920-1-chiu@endlessm.com>

[-- Attachment #1: Type: text/plain, Size: 6650 bytes --]

Hi Chris,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.20-rc4 next-20181130]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chris-Chiu/HID-input-support-Microsoft-wireless-radio-control-hotkey/20181130-150723
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from drivers/hid/usbhid/hiddev.c:35:0:
   drivers/hid/usbhid/hiddev.c: In function 'hiddev_connect':
   include/linux/hid.h:839:99: error: expected expression before '||' token
    #define IS_INPUT_APPLICATION(a) (((a >= 0x00010000) && (a <= 0x00010008)) || (a == 0x00010080) || || (a == 0x0001000c) || (a == 0x000c0001) || ((a >= 0x000d0002) && (a <= 0x000d0006)))
                                                                                                      ^
>> drivers/hid/usbhid/hiddev.c:906:9: note: in expansion of macro 'IS_INPUT_APPLICATION'
           !IS_INPUT_APPLICATION(hid->collection[i].usage))
            ^~~~~~~~~~~~~~~~~~~~

vim +/IS_INPUT_APPLICATION +906 drivers/hid/usbhid/hiddev.c

^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  891  
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  892  /*
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  893   * This is where hid.c calls us to connect a hid device to the hiddev driver
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  894   */
93c10132 drivers/hid/usbhid/hiddev.c Jiri Slaby         2008-06-27  895  int hiddev_connect(struct hid_device *hid, unsigned int force)
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  896  {
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  897  	struct hiddev *hiddev;
4916b3a5 drivers/usb/input/hiddev.c  Jiri Kosina        2006-12-08  898  	struct usbhid_device *usbhid = hid->driver_data;
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  899  	int retval;
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  900  
93c10132 drivers/hid/usbhid/hiddev.c Jiri Slaby         2008-06-27  901  	if (!force) {
93c10132 drivers/hid/usbhid/hiddev.c Jiri Slaby         2008-06-27  902  		unsigned int i;
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  903  		for (i = 0; i < hid->maxcollection; i++)
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  904  			if (hid->collection[i].type ==
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  905  			    HID_COLLECTION_APPLICATION &&
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16 @906  			    !IS_INPUT_APPLICATION(hid->collection[i].usage))
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  907  				break;
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  908  
93c10132 drivers/hid/usbhid/hiddev.c Jiri Slaby         2008-06-27  909  		if (i == hid->maxcollection)
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  910  			return -1;
93c10132 drivers/hid/usbhid/hiddev.c Jiri Slaby         2008-06-27  911  	}
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  912  
bbdb7daf drivers/usb/input/hiddev.c  Oliver Neukum      2006-01-06  913  	if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL)))
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  914  		return -1;
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  915  
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  916  	init_waitqueue_head(&hiddev->wait);
826d5982 drivers/usb/input/hiddev.c  Dmitry Torokhov    2006-07-19  917  	INIT_LIST_HEAD(&hiddev->list);
cdcb44e8 drivers/hid/usbhid/hiddev.c Jiri Kosina        2007-05-10  918  	spin_lock_init(&hiddev->list_lock);
07903407 drivers/hid/usbhid/hiddev.c Oliver Neukum      2008-12-16  919  	mutex_init(&hiddev->existancelock);
76052749 drivers/hid/usbhid/hiddev.c Jiri Kosina        2009-01-07  920  	hid->hiddev = hiddev;
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  921  	hiddev->hid = hid;
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  922  	hiddev->exist = 1;
07903407 drivers/hid/usbhid/hiddev.c Oliver Neukum      2008-12-16  923  	retval = usb_register_dev(usbhid->intf, &hiddev_class);
07903407 drivers/hid/usbhid/hiddev.c Oliver Neukum      2008-12-16  924  	if (retval) {
4291ee30 drivers/hid/usbhid/hiddev.c Joe Perches        2010-12-09  925  		hid_err(hid, "Not able to get a minor for this device\n");
76052749 drivers/hid/usbhid/hiddev.c Jiri Kosina        2009-01-07  926  		hid->hiddev = NULL;
07903407 drivers/hid/usbhid/hiddev.c Oliver Neukum      2008-12-16  927  		kfree(hiddev);
07903407 drivers/hid/usbhid/hiddev.c Oliver Neukum      2008-12-16  928  		return -1;
07903407 drivers/hid/usbhid/hiddev.c Oliver Neukum      2008-12-16  929  	}
9143059f drivers/hid/usbhid/hiddev.c Benjamin Tissoires 2017-03-08  930  
9143059f drivers/hid/usbhid/hiddev.c Benjamin Tissoires 2017-03-08  931  	/*
9143059f drivers/hid/usbhid/hiddev.c Benjamin Tissoires 2017-03-08  932  	 * If HID_QUIRK_NO_INIT_REPORTS is set, make sure we don't initialize
9143059f drivers/hid/usbhid/hiddev.c Benjamin Tissoires 2017-03-08  933  	 * the reports.
9143059f drivers/hid/usbhid/hiddev.c Benjamin Tissoires 2017-03-08  934  	 */
9143059f drivers/hid/usbhid/hiddev.c Benjamin Tissoires 2017-03-08  935  	hiddev->initialized = hid->quirks & HID_QUIRK_NO_INIT_REPORTS;
9143059f drivers/hid/usbhid/hiddev.c Benjamin Tissoires 2017-03-08  936  
733aca90 drivers/hid/usbhid/hiddev.c Jaejoong Kim       2017-03-03  937  	hiddev->minor = usbhid->intf->minor;
733aca90 drivers/hid/usbhid/hiddev.c Jaejoong Kim       2017-03-03  938  
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  939  	return 0;
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  940  }
^1da177e drivers/usb/input/hiddev.c  Linus Torvalds     2005-04-16  941  

:::::: The code at line 906 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26902 bytes --]

      parent reply	other threads:[~2018-11-30 15:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30  6:46 [PATCH] HID: input: support Microsoft wireless radio control hotkey Chris Chiu
2018-11-30 10:46 ` kbuild test robot
2018-11-30 11:18 ` Benjamin Tissoires
2018-12-05  0:56   ` Chris Chiu
2018-12-07  4:07     ` Chris Chiu
2018-12-07 13:02       ` Benjamin Tissoires
2018-11-30 15:03 ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201811302350.rf2toQVX%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=chiu@endlessm.com \
    --cc=jikos@kernel.org \
    --cc=kbuild-all@01.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessm.com \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).